Issue 83: Panic: get_tier_name+0x1a/0xb0
Status:  Fixed
Owner:
Closed:  Jul 2009
Cc:
Project Member Reported by sandeepksinha, Jul 13, 2009
What steps will reproduce the problem?
1. insmod ohsm.ko
2. enable ohsm
3. try to copy any files to mounted directoty

What is the expected output? What do you see instead?

Should have worked. We see a panic instead.
[18705.636332] IP: [<f84f2eca>] get_tier_name+0x1a/0xb0 [ohsm]            
                                                                          
                                            
[18705.636351] *pde = 7551b067                                            
                                                                          
                                            
[18705.636358] Oops: 0000 [#1] SMP                                        
                                                                          
                                            
[18705.636366] last sysfs file:
/sys/devices/pci0000:00/0000:00:1c.1/0000:03:00.0/rfkill/rfkill1/state    
                                                                          
            
[18705.636374] Modules linked in: ohsm ext2 isofs udf crc_itu_t nls_cp437
cifs af_packet binfmt_misc ppdev rfcomm bridge stp bnep sco l2cap bluetooth
autofs4 ipv6 pci_slot sbs sbshc container sbp2 lp parport
snd_hda_codec_analog snd_hda_intel snd_hda_codec snd_pcm_oss joydev
snd_mixer_oss snd_pcm snd_seq_dummy snd_seq_oss snd_seq_midi snd_rawmidi
arc4 snd_seq_midi_event ecb snd_seq snd_timer snd_seq_device iwlagn pcmcia
iwlcore thinkpad_acpi snd psmouse rfkill mac80211 led_class soundcore
intel_agp yenta_socket rsrc_nonstatic iTCO_wdt usbhid snd_page_alloc
serio_raw agpgart pcmcia_core iTCO_vendor_support ac battery hid video
output nvram cfg80211 pcspkr processor button evdev wmi ext3 jbd mbcache
sr_mod cdrom sg ata_generic pata_acpi ata_piix ohci1394 ieee1394 ehci_hcd
uhci_hcd e1000e usbcore dm_mod thermal fan fuse                           
                                                                          
                 
[18705.636547]                                                            
                                                                          
                                                                          
            
[18705.636555] Pid: 22649, comm: cp Not tainted (2.6.30 #1) 7665AD6       
                                                                          
                                                                          
            
[18705.636562] EIP: 0060:[<f84f2eca>] EFLAGS: 00010246 CPU: 1             
                                                                          
                                                                          
            
[18705.636572] EIP is at get_tier_name+0x1a/0xb0 [ohsm]                   
                                                                          
                                                                          
            
[18705.636578] EAX: 0819d2d8 EBX: 00000003 ECX: 00000082 EDX: 00000000    
                                                                          
                                                                          
            
[18705.636585] ESI: e3543d8c EDI: d80286e8 EBP: e3543d80 ESP: e3543d64    
                                                                          
                                                                          
            
[18705.636591]  DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068              
                                                                          
                                                                          
            
[18705.636598] Process cp (pid: 22649, ti=e3542000 task=d8910c70
task.ti=e3542000)                                                         
                                                                          
                      
[18705.636603] Stack:                                                     
                                                                          
                                                                          
            
[18705.636607]  d80286e8 e3543d8c d80286e8 e3543d80 d80286e8 e3543d8c
d80286e8 e3543e94                                                         
                                                                          
                 
[18705.636622]  f84f2f97 f84f4433 00632e61 00000020 00000000 c0616408
00000403 00000000                                                         
                                                                          
                 
[18705.636638]  00000002 c05072e0 e3543dc0 c0148c3a e94be780 00000000
00000002 e3543dc8                                                         
                                                                          
                 
[18705.636656] Call Trace:                                                
                                                                          
                                                                          
            
[18705.636661]  [<f84f2f97>] ? ohsm_get_tier+0x37/0x92 [ohsm]             
                                                                          
                                                                          
            
[18705.636673]  [<c0148c3a>] ? wake_up_bit+0x6a/0x80                      
                                                                          
                                                                          
            
[18705.636686]  [<c01e1e71>] ? unlock_buffer+0x11/0x20                    
                                                                          
                                                                          
            
[18705.636696]  [<c01e226d>] ? ll_rw_block+0x5d/0x130                     
                                                                          
                                                                          
            
[18705.636706]  [<c01e2377>] ? __breadahead+0x37/0x40                     
                                                                          
                                                                          
            
[18705.636715]  [<f84d9d6c>] ? ext2_new_inode+0x94c/0xa80 [ext2]          
                                                                          
                                                                          
            
[18705.636732]  [<c01d6f4a>] ? mntput_no_expire+0x1a/0x100                
                                                                          
                                                                          
            
[18705.636743]  [<c0222f8e>] ? security_inode_permission+0x1e/0x20        
                                                                          
                                                                          
            
[18705.636754]  [<c01cac48>] ? __link_path_walk+0x548/0xdb0               
                                                                          
                                                                          
            
[18705.636764]  [<c01d1fcd>] ? __d_lookup+0x8d/0x100                      
                                                                          
                                                                          
            
[18705.636773]  [<c01d6f4a>] ? mntput_no_expire+0x1a/0x100                
                                                                          
                                                                          
            
[18705.636783]  [<f84dcd00>] ? ext2_create+0x100/0x110 [ext2]             
                                                                          
                                                                          
            
[18705.636800]  [<c01ca3bd>] ? vfs_create+0x9d/0xc0                       
                                                                          
                                                                          
            
[18705.636808]  [<c01cc9f6>] ? do_filp_open+0x756/0x820                   
                                                                          
                                                                          
            
[18705.636818]  [<c01a6281>] ? handle_mm_fault+0x111/0x720                
                                                                          
                                                                          
            
[18705.636829]  [<c01c9735>] ? getname+0x25/0x100                         
                                                                          
                                                                          
            
[18705.636838]  [<c01bede5>] ? do_sys_open+0x65/0x100                     
                                                                          
                                                                          
            
[18705.636848]  [<c01beee9>] ? sys_open+0x29/0x40                         
                                                                          
                                                                          
            
[18705.636856]  [<c0102ffc>] ? sysenter_do_call+0x12/0x28                 
                                                                          
                                                                          
            
[18705.636866] Code: 06 00 00 eb 85 8d b6 00 00 00 00 8d bf 00 00 00 00 55
89 e5 83 ec 1c 89 75 f8 89 c6 a1 94 52 4f f8 89 5d f4 89 d3 31 d2 89 7d fc
<8b> b8 ac 08 00 00 85 ff 75 0f 8b 5d f4 89 d0 8b 75 f8 8b 7d fc          
            
[18705.636959] EIP: [<f84f2eca>] get_tier_name+0x1a/0xb0 [ohsm] SS:ESP
0068:e3543d64                                                             
                                                                          
                
[18705.636973] CR2: 000000000819db84                                      
                                                                          
                                                                          
            
[18705.636980] ---[ end trace 7a51fc5985c46c30 ]---       



Jul 13, 2009
Project Member #1 sandeepksinha
Attaching the files which were changed in the kernel.
Assigning it to vineet.


inode.c
43.3 KB   View   Download
ialloc.c
18.6 KB   View   Download
balloc.c
52.0 KB   View   Download
ext2.h
6.7 KB   View   Download
ext2_fs.h
19.4 KB   View   Download
Owner: checkout.vineet
Jul 13, 2009
Project Member #2 sandeepksinha
Attaching namei.c
namei.c
9.6 KB   View   Download
Jul 13, 2009
Project Member #3 imreckless@gmail.com
Hello everyone,

The error was due to not using copy_from_user to
copy user space data structures to kernel space.

We have modified admin.c and used copy_from_user 
for copying data structures.

code is corrected in svn revision 139


Status: Fixed
Cc: fscops