My favorites | Sign in
Project Home Downloads Wiki Issues Source
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 110: code does not pass checkpatch.pl
  Back to list
 
Project Member Reported by greg.fre...@gmail.com, Jul 28, 2009

The kernel team has strong coding style guidelines they expect every
patch/submission to follow.

See Documentation/CodingStyle

Those aspects of the style that can be easily checked are checked via
scripts/checkpatch.pl

As an example scripts/checkpatch.pl --file admin.c is currently returning
250 errors.

We need to get this down to zero, or in the patch submission description
provide a strong reason why we are not following the CodingStyle.

I made this priority high because our current goal is to give any kernel
hackers that peruse the code a positive impression that we are indeed
shooting for mainstream quality code.


Jul 28, 2009
Project Member #1 sandeepksinha
Absolutely it is important to get this down. Assigning it to myself.
Manish is working on admin.c now, one he is done, I will take that forward from there.
Owner: sandeepksinha
Aug 4, 2009
Project Member #2 greg.fre...@gmail.com
The test branch has made significant progress on this and there are 0 errors in the
kernel portion.  

But, the ext2 kernel patch itself is still not clean.

#scripts/checkpatch.pl patch_ohsm_2.6.30                                            

total: 57 errors, 16 warnings, 455 lines checked

Might be a good starting point for one of the students.


Powered by Google Project Hosting