| Issue 26: | Fix undo and redo of pivot and set root commands | |
| 1 person starred this issue and may be notified of changes. | Back to list |
The problem here is that set root is implemented by a sequence of pivots. Pivots have correct undo and redo, but the sequence as a whole is put on the undo stack as one big command. It is not correct because it doesn't record the position of each item in a node's list of children. This information gets messed up when the whole sequence is replayed by the inverse set root command. The stack records the state as before the set root command, and tries to set root back to that state. One way to fix this might be to let groups of subcommands be put on the stack; each subcommand is undone is order, not as a whole. But it's also possible the idea of having a list of children is misguided. Perhaps a set of children with optional hints on how to order then would work better. I'm not sure I've explained it very well, but we'll see...
Aug 23, 2015
Project Member
#1
ejrh00@gmail.com
Status:
WontFix
|