| Issue 435: | cannot have 0 as a node key | |
| 1 person starred this issue and may be notified of changes. | Back to list |
What steps will reproduce the problem?
1. Create a dynatree tree. The first element in children data has key=0.
2. jquery.dynatree.js, line 124: if( !data.key ){
3. This line causes a problem as !0 is evaluaded as false, even though its a valid key in my case (it's an id taken from the db).
If possible, please attach an example HTML file (e.g. a copy of `doc/_test-
ISSUE.html`), that reproduces the problem when copied
into the dynatree/doc/ folder or reproduce on jsFiddle:
1. open http://jsfiddle.net/mar10/xj5au/
2. [Fork] - Modify code - [Update] - [Share]
What is the expected output? What do you see instead?
Can we rollback this line to its previous version?
if( data.key === undefined ){
What version of the dynatree and jQuery are you using?
dynatree - v1.2.4 - 2013-02-12
jquery - 1.9.1
On what operating system and browser?
Windows 7, IE 9
What DOCTYPE declaration are you using?
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
Please provide any additional information below.
Jun 6, 2013
The fix will be released with 1.2.5 but you can get it from the trunk...
Labels:
-Milestone-Release1.2.4 Milestone-Release1.2.5
|
Labels: Milestone-Release1.2.4
Mergedinto: 420