My favorites | Sign in
Project Home Downloads
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 420: Attempting to use key of 0 fails
3 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  ----
Closed:  Apr 2013


 
Reported by slubow...@gmail.com, Apr 12, 2013
What steps will reproduce the problem?
1.Create a tree, pass a node with data.key set to the number 0 (not string)

What is the expected output? What do you see instead?
Expect key to be 0. Key is arbitrary generated key instead.

What version of the dynatree and jQuery are you using?
slightly modified dynatree 1.2.4
jQuery 1.9.1

On what operating system and browser?
Windows + Chrome

What DOCTYPE declaration are you using?
<!DOCTYPE html>

Please provide any additional information below.
Code at about line 200 incorrectly treats 0 as non key. Should check for undefined instead. This is a regression as existing code using old version of dynatree works.
if( !data.key ){
    data.key = "_" + tree._nodeCount++;
}else{
    data.key = "" + data.key; //  issue 371 
}
Apr 13, 2013
Project Member #1 moo...@wwwendt.de
(No comment was entered for this change.)
Status: Accepted
Labels: Milestone-Release1.2.5
Apr 13, 2013
Project Member #2 moo...@wwwendt.de
This issue was closed by revision r663.
Status: Fixed
Jun 6, 2013
Project Member #3 moo...@wwwendt.de
 Issue 435  has been merged into this issue.
Jun 6, 2013
Project Member #4 moo...@wwwendt.de
 Issue 435  has been merged into this issue.
Sep 7, 2013
Project Member #5 moo...@wwwendt.de
 Issue 445  has been merged into this issue.

Powered by Google Project Hosting