My favorites | Sign in
Project Home Downloads
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 402: removeChild function
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  ----
Closed:  Feb 2013


 
Reported by Eboqu...@gmail.com, Feb 11, 2013
Fix for  issue 399  cause all sibling nodes to be removed when a node is removed.
Problem Code:
jquery.dynatree.js line 1436 in removeChild function:

if(this.ul){
    $('li',$(this.ul)).remove()};
}

Solution:

if(this.ul){
    this.ul.removeChild(tn.li);
}

Rationale, the solution for the original issue was wrapping the removeChild statement in an if statement in the event that this.ul is null.

 - Dynatree v1.2.3 
 - jQuery 1.8.0
 - Firefox 18.0
----------------------------------------------------------------------
Original Issue:
1.Removing a node with multiple siblings

I occasionally receive uncaught exception: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIDOMHTMLUListElement.removeChild]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)" 

Problem Code:
jquery.dynatree.js line 1380 in removeChild function:

    this.ul.removeChild(tn.li);

Replace with (per the 231 issue fix in removeChildren function):

if(this.ul){
    $('li',$(this.ul)).remove()}
}
 - Dynatree v1.2.0 (minimized version)
 - jQuery 1.8.0
 - Firefox 18.0
Feb 12, 2013
Project Member #1 moo...@wwwendt.de
(No comment was entered for this change.)
Status: Assigned
Labels: -Priority-Medium Priority-High Milestone-Release1.2.4
Feb 12, 2013
Project Member #2 moo...@wwwendt.de
This issue was closed by revision r643.
Status: Fixed
Feb 12, 2013
Project Member #3 moo...@wwwendt.de
@Eboquist: could you please verify?
Feb 12, 2013
#4 Eboqu...@gmail.com
Confirmed. This fix solves issues 399 and 402.

Powered by Google Project Hosting