| Issue 303: | "where to place" marker (v.1.2.1_rc3) and "options.$trigger" bugs (v.1.2.0) | |
| 1 person starred this issue and may be notified of changes. | Back to list |
in v.1.2.0 everything I need works well. But "options.$trigger" can't return object. I update dynatree to v.1.2.1_rc3 - "options.$trigger" works well, but while DND, "where to place" marker became invisible. What's wrong? I've no ideas. video - http://www.youtube.com/watch?v=6aN97M0_Ezw Thank's a lot for reply and sorry for my English :)
Mar 26, 2012
#1
isplas...@gmail.com
Mar 26, 2012
new kind of this bug :) In source code I've chage nothing video - http://www.youtube.com/watch?v=efEgmbJLHGs
Mar 26, 2012
simple solution
correct jquery.dynatree.js as:
uncomment block and
line 2544 this.$dndMarker.css("display", "block");
line 2553 not "var pos = $target.offset();" but "var pos = $target.position();"
Mar 27, 2012
cool videos - thanks for the efforts ;-)
Status:
Accepted
Labels: Milestone-Release1.2.1
Apr 1, 2012
nevermind ;)
Apr 3, 2012
isplas...@gmail.com, I don't believe your solution is for v.1.2.1_rc3. The lines are different than what you show (they don't even exist in this version). If anyone knows the v.1.2.1_rc3 solution, please let me know. This specific issue (the bug shown in your second video) is causing me to consider a switch to the latest Telerik MVC treeview, which I'd rather avoid, since I did a tremendous amount of work using the DynaTree API. Thanks.
Apr 8, 2012
what doctype and browser do are you using? (I'd recommend strict mode: <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">) could you send a sample html file that I can drop into the /doc folder to reproduce it?
Apr 8, 2012
(No comment was entered for this change.)
Status:
Waiting
Apr 11, 2012
see also issue 258
Apr 11, 2012
I'm using the standard HTML5 DOCTYPE: <!DOCTYPE html> This happens on these 7 browsers (latest releases of each): Windows ======= Chrome IE FF Safari Mac === Chrome FF Safari Are you recommending I try changing element.offset() to element.css() (as mentioned in issue 258 )? I'll try -- if that doesn't work, I'll have to create a demo (I can't send you my client's code). Thanks.
Apr 11, 2012
The example browser contains some test cases (Test/DTD/HTML5) Can you reproduce it there? Or send me a little demo, then I will try to apply splash's patch and see if it fixes it. (258 was rather a reference for myself - the change was already made there.)
Apr 12, 2012
It works perfectly fine in the example browser. I'm also using Dynatree $Version: 1.2.1_rc3$, jQuery UI 1.8.7, jQuery 1.7.1. Here's the setup code (with some name changes to protect the client), although without the full source, it may not help you. But maybe something I'm doing wrong will jump out at you. The tree is built dynamically. I'll have to work on a full sample once my deadline is over. Thanks.
$("#myTree").dynatree({
onActivate: function (node) {
setNodeDetails(node);
window.validateExpression();
},
activeVisible: true,
clickFolderMode: 3,
autoFocus: true,
persist: false,
onExpand: function (expanded, node) {
//saveExpandedSetting(expanded, node);
},
imagePath: "/content/dynatree/skin",
noLink: false,
dnd: {
preventVoidMoves: true,
autoExpandMS: 1000,
onDragStart: function (sourceNode) {
if (!sourceNode) return false;
return true;
},
onDragEnter: function (node, sourceNode) {
if (!node || !sourceNode) return false;
if (node.isDescendantOf(sourceNode)) return false;
return true;
},
onDrop: function (node, sourceNode, hitMode) {
if (!node || !sourceNode) return;
treeDropHandler(node, sourceNode, hitMode);
}
}
});
Jun 6, 2012
Deferred, so v1.2.1 can be released shortly.
Labels:
-Milestone-Release1.2.1 Milestone-Release1.2.2
|