My favorites | Sign in
Project Home Downloads
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 285: Emptying Lazy Loaded Nodes Causes Reload / Duplicate Children
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  ----
Closed:  Jun 2012


 
Reported by peter.do...@ddrit.com, Feb 21, 2012
What steps will reproduce the problem?
1. Drag all children out of lazy loaded node
2. Collapse and expand the node
3. Notice that the children re-appear (and are now duplicated)

Detected in version 1.2.0 in Chrome (win7)

To fix, update the move function as follows:

// Unlink this node from current parent
if( this.parent.childList.length == 1 ) {
  this.parent.childList = [];
  // this.parent.bExpanded = false;
} else {
Feb 21, 2012
#1 peter.do...@ddrit.com
Related to this are 2 more code fixes:

hasChildren function needs to change the final return to:

return !!this.childList && this.childList.length > 0;

isLastSibling function needs to change return to:

return !p || !p.childList || p.childList[p.childList.length-1] === this;
Feb 21, 2012
Project Member #2 moo...@wwwendt.de
(No comment was entered for this change.)
Status: Accepted
Labels: Milestone-Release1.2.1
Jun 9, 2012
Project Member #3 moo...@wwwendt.de
I used a slight variation of your first patch. Could you check if the second two patches are still required?
Jun 9, 2012
Project Member #4 moo...@wwwendt.de
This issue was closed by revision r602.
Status: Fixed

Powered by Google Project Hosting