| Issue 137: | Test with jQueryUI 1.8 | |
| 2 people starred this issue and may be notified of changes. | Back to list |
|
Mar 7, 2010
#1
kosmas.s...@googlemail.com
Mar 8, 2010
At least for us, the changes between jQuery UI 1.7 -> 1.8 are causing things like the defaults hash to not be found (and various issues fail from there). See http://forum.jquery.com/topic/widget-factory-options-vs-defaults. Also, the API has changed for _init() (AGAIN!) to _create(), so the current 0.5.2 _init needs to possibly be changed too..._create being used for initial instantiation and the new _init() being used for per call "default actions". While not a final fix, here is a small patch that I'm playing with to get us unstuck here at Webvanta: --- /Users/chaupt/Development/webvanta/base/public/webvanta/js/jquery/1.3/plugins/dynatree/0.5.2/jquery.dynatree.original.js 2010-03-08 12:25:23.000000000 -0800 +++ /Users/chaupt/Development/webvanta/base/public/webvanta/js/jquery/1.3/plugins/dynatree/0.5.2/jquery.dynatree.js 2010-03-08 12:24:47.000000000 -0800 @@ -1752,8 +1752,16 @@ return this._init(); }, + _init: function() { - logMsg("Dynatree._init(): version='%s', debugLevel=%o.", DynaTree.version, this.options.debugLevel); + _log("warn", "ui.dynatree._init() was called; no current default functionality."); + }, + + _create: function() { + logMsg("Dynatree._create(): version='%s', debugLevel=%o.", DynaTree.version, this.options.debugLevel); + + if( parseInt($.ui.version.charAt(2)) >= 8 ) + this.options = $.extend(true, $[this.namespace][this.widgetName].defaults, this.options ); var opts = this.options; // The widget framework supplies this.element and this.options. @@ -1768,7 +1776,7 @@ // Create the DynaTree object this.tree = new DynaTree(this); this.tree._load(); - this.tree.logDebug("Dynatree._init(): done."); + this.tree.logDebug("Dynatree._create(): done."); }, bind: function() {
Mar 13, 2010
http://docs.jquery.com/UI/Upgrade_Guide_18#Widget_Factory http://github.com/scottgonzalez/jquery-ui-1.8-widget-factory/blob/master/side-by-side-diff.txt
Mar 15, 2010
Wow, many thanks ! This patch works like a charm for me !
Mar 15, 2010
Fixed with 0.5.3
Status:
Fixed
Mar 15, 2010
Fixed with 0.5.3
Jul 17, 2012
considered verified
Status:
Verified
|