My favorites | Sign in
Project Home Wiki Issues Source
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 54: Allow control of pagination
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  rwpoul...@gmail.com
Closed:  Mar 2009


 
Reported by lu...@die.net.au, Mar 4, 2009
It would be nice if the level of pagination could be controlled either in
settings, as a view parameter or on a per user basis. Each method has it's
advantages and disadvantages.

Before I patch the code, I'd be interested in what method would be preferable?

Mar 4, 2009
#1 lu...@die.net.au
Sorry, this should be changed to an Enhancement, not a Defect.
Mar 7, 2009
Project Member #2 rwpoul...@gmail.com
I don't really see the benefit of making this a per-user option. How about making it
a setting with a sensitble default? This means they can change the pagination setup
without touching the code. If we did it in urls.py, the user would have to change
code to change the setting.

Thoughts?
Labels: -Type-Defect Type-Enhancement
Mar 7, 2009
#3 lu...@die.net.au
I agree. What I have done for now is use settings.FORUM_PAGINATION and replaced the
hard coded values in the forum views. I could send a patch if you like, but it's a
fairly trivial change set.
Mar 8, 2009
Project Member #4 rwpoul...@gmail.com
If you could send a patch it'd make life much easier :)  If you don't get one through
in the next few days I'll whip something up.
Status: Started
Mar 8, 2009
#5 lu...@die.net.au
Here it is.
pagination.diff
1.4 KB   View   Download
Mar 8, 2009
Project Member #6 rwpoul...@gmail.com
Thanks for that; added in SVN r40.
Status: Fixed
Owner: rwpoulton

Powered by Google Project Hosting