Skip to content
This repository was archived by the owner on Mar 7, 2024. It is now read-only.

OpenID PHP 5.3 fixes #161

Closed
GoogleCodeExporter opened this issue Mar 14, 2015 · 5 comments
Closed

OpenID PHP 5.3 fixes #161

GoogleCodeExporter opened this issue Mar 14, 2015 · 5 comments

Comments

@GoogleCodeExporter
Copy link

Current OpenID plugin version 3.3.2 doesn't work with PHP 5.3. The fix is 
well known, see e.g. http://patchlog.com/wordpress/openid-server-on-php-5-
3/. The subversion trunk still doesn't have this fix so I'd like to repost 
it here:

<pre>
--- openid/Auth/OpenID/Server.php   2009-11-07 01:52:58.000000000 +0200
+++ openid-fixed/Auth/OpenID/Server.php 2009-11-26 17:32:43.000000000 +0200
@@ -1573,7 +1573,7 @@

         if (!is_a($handlerCls, 'Auth_OpenID_ServerError')) {
             return call_user_func_array(array($handlerCls, 'fromMessage'),
-                                        array($message, $this->server));
+                                        array(&$message, $this->server));
         } else {
             return $handlerCls;
         }
@@ -1699,7 +1699,7 @@
     {
         if (method_exists($this, "openid_" . $request->mode)) {
             $handler = array($this, "openid_" . $request->mode);
-            return call_user_func($handler, $request);
+            return call_user_func($handler, &$request);
         }
         return null;
     }
</pre>

Hope this fix will be incorporated in the next version.

Original issue reported on code.google.com by axu...@gmail.com on 17 Mar 2010 at 12:41

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant