-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better control over which files pub publishes and provides to barback #9841
Comments
Removed Type-Defect label. |
We've talked about this too. I don't think we'll get to it soon, but it's a good idea. Added this to the Later milestone. |
Removed this from the Later milestone. |
This comment was originally written by @Fox32 Is it possible was already implemented, but using the .gitignore file? I have trouble with some pub serve and files that are on the .gitignore. The files are not served as long they are on the .gitignore. Is is possible to use a seperate .pubignore instead? |
Pub has always ignored .gitignored files for the purposes of publishing, and relatively recently it began ignoring them for "pub build" and "pub serve" as well. This issue is still open because we thing a special .pubignore might be a good idea, but we don't really have time to devote to designing/implementing it in the near future. |
This comment was originally written by @Fox32 Is it somewhere in the documentation? Because I had to learn about the .gitignore feature in pub serve the hard way. |
I'm not sure it is. Can you file an issue to add it! |
Removed Oldschool-Milestone-Later label. |
This bug was originally asking for a .pubignore file, but I'm going to retarget and broaden it to describe the underlying problem. Pub needs to determine two things:
For a long time, the rule for 1. was:
This isn't a perfect solution, but it's seemed to have worked pretty well. We recently extended the same logic to pub build, and based on lots of feedback, it's not the right choice. It did solve some issues (#12102, #11198), but it's caused even more. I don't know what the solution should be yet, but I think we need to address it soon. This will be the tracking bug for it. Natalie, I added you as owner because you most recently touched this, but I'm also fine with implementing the solution once we decide what to do here. Set owner to @nex3. |
Issue #20749 has been merged into this issue. |
Issue #20795 has been merged into this issue. |
Is this going to happen for 1.7? |
Set owner to @munificent. |
I've rolled back the behavior in pub that makes it use the .gitignore file for build/serve. (It still uses it for publish, like it always has). This gets us back to the old not-great-but-not-totally-painful behavior: https://codereview.chromium.org/342553002/ I'm leaving this bug open because we still need something user-configurable, but I'm lowering the priority now that the critical pain point is fixed. Removed this from the 1.7 milestone. |
Issue #21349 has been merged into this issue. cc @munificent. |
This issue has been moved to dart-lang/pub#508. |
This issue was originally filed by voj...@google.com
pub publish should allow .pubignore or something - there are files (eg. tests or other development specific that I don’t wanna publish, but I wanna keep in git, so using .gitignore is not flexilbe enough, even though it's a good default).
The text was updated successfully, but these errors were encountered: