Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove N from all expectAsyncN #9780

Closed
DartBot opened this issue Apr 8, 2013 · 5 comments
Closed

Remove N from all expectAsyncN #9780

DartBot opened this issue Apr 8, 2013 · 5 comments
Assignees
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Apr 8, 2013

This issue was originally filed by amouravski@google.com


This is generally waiting for issue #2706 , but here's a potential solution.

typedef dynamic async0();
typedef dynamic async1(dynamic a);
typedef dynamic async2(dynamic a, dynamic b);
...

Function expectAsync(Function callback, ...) {
  if (callback is async0) {
    return expectAsync0(callback, ...);
  } else if (callback is async1) {
    return expectAsync1(callback, ...);
  } else if ( ... ) {
    ...
  } else {
    throw "Too many arguments."
  }
}

Probably not worth changing this right now, but maybe in unittest v2.

@kevmoo
Copy link
Member

kevmoo commented Feb 12, 2014

Added Pkg-Unittest label.

@kevmoo
Copy link
Member

kevmoo commented Feb 12, 2014

Removed Area-UnitTest label.
Added Area-Pkg label.

@kevmoo
Copy link
Member

kevmoo commented Feb 12, 2014

Deprecated in r32449

Leaving this issue open to track final removal.


Set owner to @kevmoo.
Added Started label.

@kevmoo
Copy link
Member

kevmoo commented May 12, 2014

r36047


Added Fixed label.

@DartBot DartBot added Type-Enhancement P3 A lower priority bug or feature request area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels May 12, 2014
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/test#202.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

2 participants