Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in spec v0.06 chapter 7. Classes #954

Closed
DartBot opened this issue Dec 23, 2011 · 2 comments
Closed

Issues in spec v0.06 chapter 7. Classes #954

DartBot opened this issue Dec 23, 2011 · 2 comments
Assignees
Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language).

Comments

@DartBot
Copy link

DartBot commented Dec 23, 2011

This issue was originally filed by ief...@unipro.ru


  1. 7.1.1 Abstract Methods
    Invoking an abstract method always results in a run-time error. This may be NoSuchMethodError or a sbuclass, such as AbstractMethodError.

Probably, it is better to change NoSuchMethodError -> NoSuchMethodException
Also probably the spec should specify that this must be NoSuchMethodException or its subclass.

  1. 7.1.2 Operators
     a) Grammar contains ! operator, however it is not contained in the list of allowed operators below the grammar.
     b) prefixOperator is obsolete?
  2. 7.2 Getters
    It is a static warning if a getter m1 overrides (7.8.1) a getter or method m2 ...

It is written in the previous statements that a getter cannot override a method. It is possible to safely remove "or method" words.

  1. 7.3 Setters
    The same as (3) - it is possible to safely remove "or method" words.
  2. 7.3 Setters
    setterSignature:
    static? returnType? ...

"static" should be in bold.

  1. 7.4 Instance Variables
    If an instance variable declaration has one of the forms ... the the expression e must be a compile-time constant.

Probably it should be written explicitly that a compile-time error occurs if the expression e is not a compile-time constant?

  1. 7.5 Constructors
    Probably it is worth to add a note that says that default constructor will not be generated if a class has at least one constructor.
  2. 7.5.1 Generative constructors
    It is not specified what happens if a redirecting constructor redirects execution to itself, or there is a longer cycle of constructors redirection.
  3. 7.5.1 Generative constructors
    It is not specified what happens if a redirecting constructor has initializing formals (currently, compile-time error in VM)
@dgrove
Copy link
Contributor

dgrove commented Jan 2, 2012

Set owner to @gbracha.
Added Area-Language, Triaged labels.

@gbracha
Copy link
Contributor

gbracha commented Jan 3, 2012

  1. Changed "may" to "must".

  2. The grammar for operator declarations does not allow !.

  3. Fixed.

  4. Fixed.

  5. Fixed.

  6. Fixed.

  7. Using iff instead of if addresses this.

  8. I is specified: you'll get a loop.

  9. Fixed.


Added Done label.

@DartBot DartBot added Type-Defect area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). labels Jan 3, 2012
dart-bot pushed a commit that referenced this issue Nov 6, 2020
2020-11-05 irina.arkhipets@gmail.com Fixes #602: New tests for least and greatest closures added.
2020-11-05 sgrekhov@unipro.ru #926. Rewrite io/Process/start_A01_t02 test to work on precompiled environment
2020-11-05 sgrekhov@unipro.ru #932. Rewrite HttpRequestUpload/onLoad_A01_t01 test to send correct HttpRequest
2020-11-04 sgrekhov@unipro.ru Fixes #956. Don't expect extension invocation on type dynamic
2020-11-04 karlklose@users.noreply.github.com Convert some multi-tests to static error framework  (#958)
2020-11-03 irina.arkhipets@gmail.com Fixes #602: dynamic tests for least and greatest closures updated.
2020-11-03 irina.arkhipets@gmail.com Fixes #602: tests for least and greatest closures added.
2020-10-28 sgrekhov@unipro.ru #926. Fix two Process tests to use 'process_test' tool
2020-10-28 sgrekhov@unipro.ru #926. Rewrite two Process tests to use 'process_test' tool
2020-10-28 sgrekhov@unipro.ru Fixes #955. Expect less specific error for typed_data tests
2020-10-26 sgrekhov@unipro.ru Fixes #954. Change the line where we expect an error for CFE
2020-10-20 sgrekhov@unipro.ru Fixes #912. Abstract variables syntax tests added
2020-10-19 sgrekhov@unipro.ru #912. More external variables syntax tests added
2020-10-17 sgrekhov@unipro.ru External variables syntax test added
2020-10-16 sgrekhov@unipro.ru #912. More test for static analysis of external variables added
2020-10-15 sgrekhov@unipro.ru #912. Test for static analysis of external variables added
2020-10-14 sgrekhov@unipro.ru #912. Test for static analysis if abstract variables added

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,analyzer-nnbd-win-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,front-end-nnbd-win-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-win-release-x64-try
Change-Id: Id9cde784918faa4e891da8c4cb448d415a7a18aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170680
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
copybara-service bot pushed a commit that referenced this issue Jun 1, 2023
…native, protobuf, pub_semver, shelf, stack_trace, tools, vector_math, webdev

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/f0f6cd2..a9543c0):
  a9543c0  2023-05-31  Devon Carew  switch to using package:dart_flutter_team_lints (#247)
  36407ea  2023-05-31  Devon Carew  adjust the validation of mandatory options (#246)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/d9b389f..c14a268):
  c14a268  2023-05-31  Kevin Moore  Bump lints, regenerate proto file, fix script (#74)

dartdoc (https://github.com/dart-lang/dartdoc/compare/950898f..39fe1a8):
  39fe1a8a  2023-05-31  Parker Lougheed  Update highlight.js to 11.8.0 for Dart 3 syntax highlighting (#3416)
  4574e819  2023-05-30  Sam Rawlins  Convert kind to an enum (#3426)

http (https://github.com/dart-lang/http/compare/18a43a2..8834aec):
  8834aec  2023-05-31  Brian Quinlan  Update readme and prepare for a new release (#954)
  aca7f0e  2023-05-31  dependabot[bot]  Bump futureware-tech/simulator-action from 1 to 2 (#936)
  7a238a9  2023-05-31  dependabot[bot]  Bump actions/labeler from 4.0.2 to 4.0.4 (#952)
  4c0eb48  2023-05-30  Brian Quinlan  Prepare to publish cupertino_http 1.0.0 (#951)

leak_tracker (https://github.com/dart-lang/leak_tracker/compare/7f2cab3..cbbdeca):
  cbbdeca  2023-05-31  Polina Cherkasova  Improve getting retaining path. (#69)

mockito (https://github.com/dart-lang/mockito/compare/40fe2ca..924f65c):
  924f65c  2023-06-01  Ilya Yanok  Add support for records

native (https://github.com/dart-lang/native/compare/76bc55e..c851e69):
  c851e69  2023-06-01  dependabot[bot]  Bump nttld/setup-ndk (#57)
  0df0cad  2023-06-01  dependabot[bot]  Bump actions/labeler from 4.0.3 to 4.0.4 (#58)
  c30faa2  2023-05-31  Daco Harkes  [c_compiler] test install_name_tool behavior (#56)
  45ef2e7  2023-05-31  Daco Harkes  [c_compiler] Support setting the install name of dylibs (#55)

protobuf (https://github.com/dart-lang/protobuf/compare/346a72d..da6953c):
  da6953c  2023-05-31  Kevin Moore  Update to latest lints and Dart SDK (#828)

pub_semver (https://github.com/dart-lang/pub_semver/compare/c034352..3930557):
  3930557  2023-05-31  Kevin Moore  Bump lints, require Dart 3.0 (#89)

shelf (https://github.com/dart-lang/shelf/compare/a404b6a..ce379aa):
  ce379aa  2023-06-01  dependabot[bot]  Bump actions/labeler from 4.0.3 to 4.0.4 (#363)

stack_trace (https://github.com/dart-lang/stack_trace/compare/86f7e30..8b2046e):
  8b2046e  2023-05-31  Devon Carew  blast_repo fixes (#134)

tools (https://github.com/dart-lang/tools/compare/d723a55..389925f):
  389925f  2023-06-01  Elias Yishak  Utility function added to check permissions on directory (#95)
  a436fee  2023-05-31  Elias Yishak  Asserts added to check all relevant GA4 limitations (#96)

vector_math (https://github.com/google/vector_math.dart/compare/cd87f57..a3aca09):
  a3aca09  2023-05-31  Lukas Klingsbo  fix: Revert negation change for Vector2 (#296)

webdev (https://github.com/dart-lang/webdev/compare/d442fa8..f565d7f):
  f565d7f1  2023-05-31  Anna Gringauze  Disable flaky test on windows (#2127)
  6eed300e  2023-05-31  Anna Gringauze  Cleanup expression evalaluation tests (#2125)

Change-Id: Ia568db23bbc923f764cdf323e249175b609d57ee
Tested: affected files are regenerated test goldens
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/306903
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language).
Projects
None yet
Development

No branches or pull requests

4 participants