-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
html: AudioNode.connect does not honor the optional-ness of the 3rd argument (input) #6728
Comments
This is looking like a dartium-html problem. It works just fine when compiled to JS. |
Not surprised since JS doesn't mind missing params... |
Just to add to this - only the first argument should actually be non-optional. According to W3C: interface AudioNode { void connect(AudioNode destination, optional unsigned long output = 0, optional unsigned long input = 0); From what I have seen of JS web audio code, it is common to only supply the first argument, so we are violating the principle of least surprise here. |
Graham, actually that part of the interface is AsDesigned. See the explanation here: https://code.google.com/p/dart/issues/detail?id=2023 HOWEVER, I do agree that it is very strange. I've been in discussions with the other html lib folk and I think we'll be making a change on this, but it's going to be pretty big in scope and affects a number of other issues in the library (that's what the holdup is on resolving this bug). |
Marked this as being blocked by #9156. |
Is it possible to remove the optional-ness of the input arg? Or at least a doc comment if this isn't going to get fixed. :-/ |
Issue #11070 has been merged into this issue. |
Added Started label. |
At long last, fixed as of r24709! Added Fixed label. |
Verified on 0.6.3.3_r24898 |
AudioNode advertises the connect method as:
void connect(destination, int output, [int input])
When the input value is omitted, though, one gets a null ref exception.
r14873
work around: provide 0 for input
The text was updated successfully, but these errors were encountered: