Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pub command to deploy a web dir #6006

Closed
sethladd opened this issue Oct 17, 2012 · 20 comments
Closed

Pub command to deploy a web dir #6006

sethladd opened this issue Oct 17, 2012 · 20 comments
Assignees
Labels
type-enhancement A request for a change that isn't a bug
Milestone

Comments

@sethladd
Copy link
Contributor

I need to deploy a web/ dir that's inside my pub package. It would be great if pub had some command to make this easy. Perhaps, create a tar.gz of web/ with the correct packages/ copy or symlink.

@munificent
Copy link
Member

Added this to the Later milestone.

@munificent
Copy link
Member

Removed this from the Later milestone.
Added this to the M3 milestone.

@munificent
Copy link
Member

Marked this as blocking #8263.

@munificent
Copy link
Member

Issue #8102 has been merged into this issue.

@munificent
Copy link
Member

Removed this from the M3 milestone.
Added this to the M4 milestone.

@munificent
Copy link
Member

Removed this from the M4 milestone.
Added this to the M5 milestone.

@nex3
Copy link
Member

nex3 commented Apr 22, 2013

Set owner to @nex3.
Added Started label.

@sethladd
Copy link
Contributor Author

Can you give us an idea of what this will do? Thanks!

@nex3
Copy link
Member

nex3 commented Apr 22, 2013

The immediate goal is just to bake all the external dependencies in to a directory with no outgoing symlinks. This directory can then be (relatively) easily copied to a server and served statically, or run locally without fear of being disrupted by e.g. deletion of the pub cache.

@sethladd
Copy link
Contributor Author

Will it handle static assets that come in from a package? e.g. dart.js ? (not sure what you mean by "external dependencies")

@nex3
Copy link
Member

nex3 commented Apr 23, 2013

We've talked this over a little more, and we have a more specific idea of what it's going to do. It'll copy everything in "web" into a deploy directory, run dart2dart and dart2js on all the entrypoints, and clean up the Dart source files. This will produce a directory that can be served without any additional steps.

@sethladd
Copy link
Contributor Author

By copy, you mean "if it's symlinked in, it'll get actually copied to this build directory". So, to get 3rd party assets like dart.js, just make sure they are in their own lib directory. ?

@nex3
Copy link
Member

nex3 commented Apr 23, 2013

The deploy directory won't have any package symlinks. All the Dart code will be compiled together using dart2dart or dart2js.

For the first iteration of this, we don't plan to support assets.

@sethladd
Copy link
Contributor Author

Thanks, I understand the deploy dir won't have symlinks. Was wondering how dart.js will get into my deploy dir. Sounds like I can add a manual copy step to get that and other static assets into deploy dir.

@nex3
Copy link
Member

nex3 commented Apr 23, 2013

Pub will need to access dart2js, but currently the relative path from pub to dart2js differs between the repo and the SDK.


Marked this as being blocked by #6619.

@dgrove
Copy link
Contributor

dgrove commented May 9, 2013

Issue #10544 has been merged into this issue.

@munificent
Copy link
Member

Issue #9996 has been merged into this issue.


cc @dgrove.

@munificent
Copy link
Member

Added Fixed label.

@DartBot
Copy link

DartBot commented Aug 21, 2013

This comment was originally written by mdem...@google.com


Any details on why this is "fixed"? I assume there's a "pub deploy" command or something now, but I'm not having any luck Googling for details about it. Also, http://pub.dartlang.org/doc/ including the "Docs" drop down menu don't mention any deploy commands.

@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#221.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

6 participants