Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use friendlier YAML formatting for pubspec.lock #5104

Closed
munificent opened this issue Sep 12, 2012 · 14 comments
Closed

Use friendlier YAML formatting for pubspec.lock #5104

munificent opened this issue Sep 12, 2012 · 14 comments
Assignees
Labels
type-enhancement A request for a change that isn't a bug
Milestone

Comments

@munificent
Copy link
Member

The lock file that pub generates doesn't use any whitespace which makes it hard to read and unfriendly in diffs. We should try to write a cleaner, more human-friendly YAML file.

@DartBot
Copy link

DartBot commented Sep 21, 2012

This comment was originally written by prujo...@gmail.com


See https://codereview.chromium.org/10968035 for my attempt at this.

@DartBot
Copy link

DartBot commented Sep 30, 2012

This comment was originally written by ross.m.smith...@gmail.com


Another option would be to support pretty JSON first:

http://code.google.com/p/dart/issues/detail?id=4464

Since the lock file is just JSON for now anyhow. Then YAML serialization would come after that (i'm also eager for the YAML library!)

@DartBot
Copy link

DartBot commented Sep 30, 2012

This comment was originally written by pr...@gmail.com


I agree. This patch is narrowly focused just to handle the .lock file until JSON/YAML come further along. :)

@munificent
Copy link
Member Author

Pushing this out to M3 since Nathan and I are quite busy. I'd like to solve this, but I would prefer a more general solution, I think.


Removed this from the M2 milestone.
Added this to the M3 milestone.

@munificent
Copy link
Member Author

Removed Type-Defect label.
Added Type-Enhancement label.

@munificent
Copy link
Member Author

Issue #5409 has been merged into this issue.

@munificent
Copy link
Member Author

Removed this from the M3 milestone.
Added this to the M4 milestone.

@munificent
Copy link
Member Author

Removed this from the M4 milestone.
Added this to the M5 milestone.

@munificent
Copy link
Member Author

Issue #10307 has been merged into this issue.

@munificent
Copy link
Member Author

Andrei suggests map keys should be sorted too, to minimize deltas in diffs.

@munificent
Copy link
Member Author

Set owner to @munificent.
Added Accepted label.

@munificent
Copy link
Member Author

Added Started label.

@munificent
Copy link
Member Author

Added Fixed label.

@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#108.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants