Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for @license and @preserve in dart2js #3954

Closed
DartBot opened this issue Jul 1, 2012 · 11 comments
Closed

Support for @license and @preserve in dart2js #3954

DartBot opened this issue Jul 1, 2012 · 11 comments
Labels
closed-obsolete Closed as the reported issue is no longer relevant P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug web-dart2js

Comments

@DartBot
Copy link

DartBot commented Jul 1, 2012

This issue was originally filed by bernd.par...@gmail.com


Please consider adding support to dart2js for preserving Dart comments in the generated JavaScript.

I was thinking along the lines of what the closure compiler does for @­license and @­preserve:
https://developers.google.com/closure/compiler/docs/js-for-compiler#tags

For example:

/**
 * @­preserve Copyright 2009 SomeThirdParty.
 * Here is the full license text and copyright
 * notice for this file. Note that the notice can span several
 * lines and is only terminated by the closing star and slash:
 */

Tells the compiler to insert the associated comment before the compiled code for the marked file. This annotation allows important notices (such as legal licenses or copyright text) to survive compilation unchanged. Line breaks are preserved.

Thank you!

@iposva-google
Copy link
Contributor

Added Area-Dart2JS, Area-Language, Triaged labels.

@gbracha
Copy link
Contributor

gbracha commented Jul 11, 2012

I don't see this as a language issue. It is an annotation that dart2js might look at in the context of deployment. I imagine it would look a bit differently:

@license('licenseURI') MyClass { ...}

which could produce either text or nice link in the output.


Removed Area-Language label.
Added Accepted label.

@kasperl
Copy link

kasperl commented Sep 3, 2012

Added this to the Later milestone.
Added Triaged label.

@kasperl
Copy link

kasperl commented Oct 17, 2012

Removed this from the Later milestone.

@kasperl
Copy link

kasperl commented Oct 17, 2012

Added this to the M2 milestone.

@peter-ahe-google
Copy link
Contributor

Removed Priority-Medium label.
Added Priority-Low label.

@peter-ahe-google
Copy link
Contributor

Removed this from the M2 milestone.
Added this to the Later milestone.
Removed Priority-Low label.
Added Priority-Medium label.

@kasperl
Copy link

kasperl commented May 23, 2013

Added TriageForM5 label.

@kasperl
Copy link

kasperl commented May 28, 2013

Removed TriageForM5 label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@sigmundch sigmundch added type-enhancement P3 A lower priority bug or feature request and removed Priority-Medium labels Dec 10, 2015
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed triaged labels Feb 29, 2016
@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-obsolete Closed as the reported issue is no longer relevant P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug web-dart2js
Projects
None yet
Development

No branches or pull requests

8 participants