Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide an API to enable Observatory from within the Dart process #23320

Closed
kevmoo opened this issue Apr 23, 2015 · 6 comments
Closed

Provide an API to enable Observatory from within the Dart process #23320

kevmoo opened this issue Apr 23, 2015 · 6 comments
Labels
area-observatory area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.

Comments

@kevmoo
Copy link
Member

kevmoo commented Apr 23, 2015

We want to be able to ship commands, like 'pub run test' or even globally activated tools that can opt-in to having the observatory running while running.

It's also important that the process can know which port observatory is listening on without having to parse stdout at runtime.

A top-level method in dart:io (or even a static on Platform)

Uri enableVMService({int port})

or similar
@kevmoo
Copy link
Member Author

kevmoo commented Apr 23, 2015

Blocking dart-lang/test#50

Added this to the 1.11 milestone.
Removed Priority-Unassigned label.
Added Priority-High label.

@iposva-google
Copy link
Contributor

This is currently not a planned feature.

Removed this from the 1.11 milestone.
Removed Priority-High label.
Added Priority-Unassigned, NotPlanned labels.

@kevmoo kevmoo added Type-Defect area-observatory closed-not-planned Closed as we don't intend to take action on the reported issue labels Apr 26, 2015
@nex3 nex3 mentioned this issue Jul 29, 2015
Closed
@nex3 nex3 mentioned this issue Oct 16, 2015
Closed
@nex3 nex3 mentioned this issue May 10, 2016
Closed
@kevmoo kevmoo reopened this Oct 13, 2016
@kevmoo kevmoo added area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. and removed closed-not-planned Closed as we don't intend to take action on the reported issue labels Oct 13, 2016
@johnmccutchan
Copy link
Contributor

https://codereview.chromium.org/2438613002

@nex3
Copy link
Member

nex3 commented Oct 31, 2016

Where are the tests? I only see one file with maybe 20 lines of actual code. Where are the tests that requests with invalid auth codes don't go through? What happens if enable is false? What happens if enable is true and there's already a server? Where are the tests for actually accessing members of ServiceProtocolInfo rather than just printing the toString()?

This also seems substantially under-documented. There's no documentation for the enable parameter, there's no indication what hostname or port will be used for the service protocol, there's no way for a new user to figure out what the "service protocol" even is.

@kevmoo
Copy link
Member Author

kevmoo commented Nov 15, 2016

Tests have been updated by @a-siva b2f3bb6

It'd be great if we could get some improved documentation here.

@joeconwaystk
Copy link

Was an option to select port ever added here? Can't find it in API ref.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-observatory area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nex3 @kevmoo @johnmccutchan @joeconwaystk @iposva-google