Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pub can fail to load transformers necessary for local development #23084

Closed
nex3 opened this issue Apr 2, 2015 · 2 comments
Closed

Pub can fail to load transformers necessary for local development #23084

nex3 opened this issue Apr 2, 2015 · 2 comments
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@nex3
Copy link
Member

nex3 commented Apr 2, 2015

If a package "foo" uses a transformer from package "bar" and restricts that transformer to only run on files in "test", "bar"'s transformer won't be loaded at all. This is due to a flaw in Pub's logic for determining necessary transformers: because "bar" only runs on non-public file and isn't from the root package, pub assumes that it's not necessary. Instead, pub should check whether it's used in the root package.

This is a serious issue for the test runner: it needs to expose a transformer for its users to use, but that transformer will only be run on tests.

@nex3
Copy link
Member Author

nex3 commented Apr 2, 2015

Fixed by r44876.


Added Fixed label.

@nex3 nex3 added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures labels Apr 2, 2015
@nex3 nex3 self-assigned this Apr 2, 2015
@DartBot
Copy link

DartBot commented Jun 4, 2015

This issue has been moved to dart-lang/pub#5.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

2 participants