Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regenerate pub_generated #21940

Closed
sigmundch opened this issue Dec 21, 2014 · 8 comments
Closed

regenerate pub_generated #21940

sigmundch opened this issue Dec 21, 2014 · 8 comments
Assignees

Comments

@sigmundch
Copy link
Member

After removing the packages, it seems that the async_compile_test is failing. I haven't looked yet at how to do so, but meanwhile, I've marked the test as failing in the pub.status file.

@sigmundch
Copy link
Member Author

@munificent
Copy link
Member

Set owner to @munificent.
Removed Priority-Unassigned label.
Added Priority-Medium, Started labels.

@DartBot
Copy link

DartBot commented Feb 10, 2015

This comment was originally written by ant...@antonmoiseev.com


I've added a new test file to test/get/git dir, but when I run ./tools/test.py --mode=release --arch=ia32 --runtime=vm pub/get/git --verbose my test is not invoked. When I turn on verbose mode I see the tests are picked up from pub_generated dir. The main question is how to add new tests to pub? Should I regenerate pub_generated every time I modify a test?

Not sure it is the right issue by it's the only place where I've found mentioning of pub_generated. Thanks.

@nex3
Copy link
Member

nex3 commented Feb 10, 2015

I'm closing this, since it was done ages ago.

Anton: Yes, if you make any changes to pub you need to rebuild the generated sources. You can do this by invoking sdk/lib/_internal/pub/bin/async_compile.dart and passing it the path to the built Dart SDK and the output directory.


Added Done label.

@DartBot
Copy link

DartBot commented Feb 10, 2015

This comment was originally written by ant...@antonmoiseev.com


Thank you, that helped!

However it seems I'm missing something. Before, I just run ./tools/test.py -m release pub to test pub every time I make a change. Now to make changes to take effect I run 3 commands:

# Regenerate pub_generated - the source of actual tests that are invoked
$ xcodebuild/ReleaseIA32/dart -p xcodebuild/ReleaseIA32/packages sdk/lib/_internal/pub/bin/async_compile.dart sdk/lib/_internal/pub_generated

# Rebuild SDK to update the snapshots. Required if I make a change in the lib directory.
$ ./tools/build.py -m release -a ia32 create_sdk

# Finally run tests
$ ./tools/test.py -m release pub

Is it a current workflow or it can be done easier?

@nex3
Copy link
Member

nex3 commented Feb 10, 2015

You can pass --snapshot-build-dir to async_compile.dart to get it to recompile the snapshot for you. But for the most part, yeah, the iteration process is more complicated now. We'd like to move over to the VM's async/await implementation as soon as possible for that reason.

@DartBot
Copy link

DartBot commented Feb 11, 2015

This comment was originally written by ant...@antonmoiseev.com


That's OK, thanks, it's still very fast. First time I work with the codebase where async/await is massively used, and absolutely love how it looks like and reads, definitely worths this slight inconvenience.

@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#1220.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants