-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regenerate pub_generated #21940
Comments
Here is a link to the example failure: http://chromegw.corp.google.com/i/client.dart/builders/pub-linux-be/builds/10113/steps/pub%20and%20pkg%20%20tests/logs/stdio |
Set owner to @munificent. |
This comment was originally written by ant...@antonmoiseev.com I've added a new test file to Not sure it is the right issue by it's the only place where I've found mentioning of pub_generated. Thanks. |
I'm closing this, since it was done ages ago. Anton: Yes, if you make any changes to pub you need to rebuild the generated sources. You can do this by invoking sdk/lib/_internal/pub/bin/async_compile.dart and passing it the path to the built Dart SDK and the output directory. Added Done label. |
This comment was originally written by ant...@antonmoiseev.com Thank you, that helped! However it seems I'm missing something. Before, I just run
Is it a current workflow or it can be done easier? |
You can pass --snapshot-build-dir to async_compile.dart to get it to recompile the snapshot for you. But for the most part, yeah, the iteration process is more complicated now. We'd like to move over to the VM's async/await implementation as soon as possible for that reason. |
This comment was originally written by ant...@antonmoiseev.com That's OK, thanks, it's still very fast. First time I work with the codebase where async/await is massively used, and absolutely love how it looks like and reads, definitely worths this slight inconvenience. |
This issue has been moved to dart-lang/pub#1220. |
After removing the packages, it seems that the async_compile_test is failing. I haven't looked yet at how to do so, but meanwhile, I've marked the test as failing in the pub.status file.
The text was updated successfully, but these errors were encountered: