Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 tests are failing on pkg windows #21071

Closed
ricowind opened this issue Sep 24, 2014 · 11 comments
Closed

4 tests are failing on pkg windows #21071

ricowind opened this issue Sep 24, 2014 · 11 comments
Assignees
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.

Comments

@ricowind
Copy link
Contributor

pkg/analysis_server/test/edit/refactoring_test
pkg/analysis_server/test/services/refactoring/move_file_test
pkg/glob/test/list_test
pkg/glob/test/match_test

From looking at it some of this may be related to winodws paths

This is both some analysis server and glob tests. Natalie/Paul, could you split this out if it is not the same

@stereotype441
Copy link
Member

Investigating


Added Started label.

@stereotype441
Copy link
Member

Set owner to @stereotype441.

@stereotype441
Copy link
Member

The analysis_server tests were failing due to two issues:

  1. the "convert getter to method" and "convert method to getter" refactorings were dropping a future on the floor, causing the refactoring to be returned to the client before it had been completely been constructed. This is fixed in revision 40637.
  2. the "move file" refactoring erroneously inserts backslashes into import statements when run on Windows. Konstantin is going to work on this.

The remaining failures (in pkg/glob) look unrelated to the analysis_server failures. Natalie, would you mind looking into those?


Set owner to @scheglov.
Added Triaged label.

@nex3
Copy link
Member

nex3 commented Sep 24, 2014

On it!


cc @scheglov.
Set owner to @nex3.
Added Started label.

@nex3
Copy link
Member

nex3 commented Sep 24, 2014

Fixed in r40644.


Added Fixed label.

@scheglov
Copy link
Contributor

Fix for move_file_test https://codereview.chromium.org/603753002

@ricowind
Copy link
Contributor Author

pkg/glob/test/list_test is still failing on windows and it still seems to be related to windows paths


Removed Area-Analyzer label.
Added Area-Pkg, Triaged labels.

@ricowind
Copy link
Contributor Author

Natalie: Bob told me that this is not being used for anything, feel free to take this off the m1.7 milestone if you think it does not need to in.

@nex3
Copy link
Member

nex3 commented Sep 25, 2014

Removed this from the 1.7 milestone.

@munificent
Copy link
Member

Set owner to @munificent.
Removed Priority-High label.
Added Priority-Medium, Started labels.

@munificent
Copy link
Member

Glob stuff fixed: https://codereview.chromium.org/603713002/


Added Fixed label.

@ricowind ricowind added Type-Defect area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Sep 26, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.
Projects
None yet
Development

No branches or pull requests

5 participants