Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please merge following CLs into branches/1.5 to reduce editor memory usage #19830

Closed
scheglov opened this issue Jul 3, 2014 · 8 comments
Closed
Assignees
Labels
merge-to-stable P1 A high priority bug; for example, a single project is unusable or has many test failures type-task
Milestone

Comments

@kasperl
Copy link

kasperl commented Jul 4, 2014

We need much more information for this. Can you provide one patch against branches/1.5 that brings over all the code needed -- and tell us how you've tested this?


Set owner to @scheglov.
Removed MergeToDev, Area- labels.
Added MergeToStable, Area-Editor, NeedsInfo labels.
Changed the title to: "Please merge following CLs into branches/1.5 to reduce editor memory usage".

@scheglov
Copy link
Contributor Author

scheglov commented Jul 4, 2014

See attached consolidated patch against 1.5 branch.

It passes all Engine unit tests and Editor tests.
I tested manually that search, refactorings and type hierarchy UI features work.

I also tested that it really has a low memory usage, using a profiler.


Attachment:
split-index.diff (225.75 KB)


Added Triaged label.

@kasperl
Copy link

kasperl commented Jul 5, 2014

Thanks, Konstantin! We will give this a try next week.


cc @scheglov.
Set owner to @ricowind.

@ricowind
Copy link
Contributor

ricowind commented Jul 7, 2014

This is now on stable builders, but it broke the plugins build, see:http://build.chromium.org/p/client.dart/builders/dart-editor-stable/builds/34/steps/dart-editor-stable/logs/stdio

@scheglov
Copy link
Contributor Author

scheglov commented Jul 7, 2014

I don't think you have applied the patch correctly.
It seems that the new files have not been added.
They are in the patch, but not in the repository.


Attachment:
[Screen Shot 2014-07-07 at 10.26.23 AM.png](https://storage.googleapis.com/google-code-attachments/dart/issue-19830/comment-5/Screen Shot 2014-07-07 at 10.26.23 AM.png) (225.88 KB)

@ricowind
Copy link
Contributor

ricowind commented Jul 7, 2014

Yes, sorry about that, I am landing a fix.

@ricowind
Copy link
Contributor

ricowind commented Jul 8, 2014

Fixed in revision r38031

@ricowind
Copy link
Contributor

ricowind commented Jul 8, 2014

Added Fixed label.

@scheglov scheglov added merge-to-stable Area-Editor type-task P1 A high priority bug; for example, a single project is unusable or has many test failures labels Jul 8, 2014
@scheglov scheglov added this to the 1.5 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-to-stable P1 A high priority bug; for example, a single project is unusable or has many test failures type-task
Projects
None yet
Development

No branches or pull requests

3 participants