Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code lab's generated JS breaks in Firefox 31 #19509

Closed
kwalrath opened this issue Jun 17, 2014 · 2 comments
Closed

Code lab's generated JS breaks in Firefox 31 #19509

kwalrath opened this issue Jun 17, 2014 · 2 comments
Labels
closed-duplicate Closed in favor of an existing report P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js

Comments

@kwalrath
Copy link
Contributor

Starting with step 3, the apps embedded in the code lab are slightly broken in Firefox 31 Beta. They're fine in Firefox 30 and every other browser I've tried.

This is being discussed on reddit:
http://www.reddit.com/r/dartlang/comments/28crq2/bad_luck_brian_wants_to_learn_dart/

I tried regenerating the code, but it didn't help:
https://chromiumcodereview.appspot.com/339243004/

To reproduce the problem:

  1. Go to either https://www.dartlang.org/codelabs/darrrt/ (original generated JS) or
    https://newjs-dot-dart-lang.appspot.com/codelabs/darrrt/ (newly generated JS).
  2. Click the link for Step 4.
  3. Scroll up until you see the name badge.
  4. Type into the field.

You should see what you type appear in the name badge. In Firefox 31 (on Mac & Windows, at least), you see no change in the badge. There's an error message.

Old JS error message:
TypeError: J.getInterceptor$x(...).get$target is not a function piratebadge.dart.js:5650

New JS error message:
TypeError: J.RE(...).gN is not a function piratebadge.dart.js:2963

In other respects, the app works. Perhaps this is a Firefox bug that we can work around and/or help them fix?

@kwalrath
Copy link
Contributor Author

Oops, I didn't see this bug had already been filed: 19489

@munificent
Copy link
Member

Added Duplicate label.
Marked as being merged into #19489.

@kwalrath kwalrath added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js closed-duplicate Closed in favor of an existing report labels Jun 17, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-duplicate Closed in favor of an existing report P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Projects
None yet
Development

No branches or pull requests

2 participants