Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link rel=import can appear anywhere #18340

Closed
jmesserly opened this issue Apr 21, 2014 · 20 comments
Closed

link rel=import can appear anywhere #18340

jmesserly opened this issue Apr 21, 2014 · 20 comments
Assignees
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. closed-not-planned Closed as we don't intend to take action on the reported issue P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone

Comments

@jmesserly
Copy link

Dartium w/ Polymer appears to support <link rel=import> and <polymer-element> in any location. Our deploy tool seems to require it to not be inside <polymer-element>.

@jmesserly
Copy link
Author

@jmesserly
Copy link
Author

and a pull request illustrating workaround: montyr75/remember_me#1

@jmesserly
Copy link
Author

bumping priority since at least two people have hit it now. Also it's a difference between Dartium and dart2js, so you don't catch it at development time


Removed Priority-Unassigned label.
Added Priority-High label.

@sigmundch
Copy link
Member

Added this to the 1.4 milestone.

@dgrove
Copy link
Contributor

dgrove commented May 17, 2014

Removed this from the 1.4 milestone.
Added this to the Polymer0.10 milestone.

@sigmundch
Copy link
Member

Issue #18794 has been merged into this issue.

@jmesserly
Copy link
Author

Added Pkg-Polymer label.

@jmesserly
Copy link
Author

Removed Pkg-Polymer label.
Added Pkg-PolymerBuild label.

@jmesserly
Copy link
Author

Removed Library-PolymerBuild label.

@jmesserly
Copy link
Author

Removed Area-Polymer label.
Added Area-Pkg label.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the Polymer0.10 milestone.
Added this to the 1.6 milestone.

@sigmundch
Copy link
Member

Removed this from the 1.6 milestone.
Added Polymer-P-1 label.

@sigmundch
Copy link
Member

Removed Polymer-P-1 label.
Added Polymer-Milestone-Next label.

@sigmundch
Copy link
Member

Added PolymerMilestone-Next label.

@sigmundch
Copy link
Member

Removed Polymer-Milestone-Next label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Added this to the 1.6 milestone.

@jakemac53
Copy link
Contributor

It looks like the linter is catching this now at least, but it would still be good to make it work.


Set owner to @jakemac53.
Added Started label.

@jakemac53
Copy link
Contributor

There are basically 3 options that I see here:

  1. Enable general nested polymer-element elements. The fix for this is pretty easy and I have a cl that works (at least in the simple cases), but this would need to be supported on the javascript side as well and its questionable as to whether its something they/we really want to support long term.
  2. Fix this in the build step for people automatically. In that case it would actually be broken for people who are running it in Dartium though without building first (it does not actually fully work as it first appears).
  3. Leave it as is with the linter warning and enforce that people just don't nest polymer elements and put their imports outside polymer-elements. I don't know of a legitimate use case for nesting polymer-elements, and we could always add support for it in the future if somebody does come up with one.

Me and sigmund@ are going to chat with the Polymer JS team and see what they have to say about supporting nested polymer-elements since we should be on the same page in order to inter-op effectively.

@jakemac53
Copy link
Contributor

We decided the best course of action was to follow whatever vulcanizer does to keep the two projects consistent. Vulcanizer currently does exactly what we are doing, so we are going to leave it as is, just with the linter warning.


Added WontFix label.

@jmesserly jmesserly added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Jul 10, 2014
@jmesserly jmesserly added this to the 1.6 milestone Jul 10, 2014
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/polymer-dart#388.

@kevmoo kevmoo added closed-not-planned Closed as we don't intend to take action on the reported issue and removed resolution-wont_fix labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. closed-not-planned Closed as we don't intend to take action on the reported issue P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

7 participants