pub build doesn't special-case the browser package when it is in dev_dependencies
#16617
Assignees
Comments
|
Added Started label. |
|
Set owner to @munificent. |
|
https://codereview.chromium.org/157743005/ Added Fixed label. |
|
This issue has been moved to dart-lang/pub#849. |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue was originally filed by dev...@futureperfect.info
1.2.0.edge_032404
Windows7x64
pubspec.yaml
name: bug
dev_dependencies:
browser: '>=0.9.0'
example/test.dart
library bug.example;
import 'dart:html';
main() {
document.body.append(new SpanElement()..text = 'Hello');
}
example/test.html
<!DOCTYPE html>
<html>
<head>
<title>Test</title>
</head>
<body>
<script type="application/dart" src="test.dart"></script>
<script src="packages/browser/dart.js"></script>
</body>
</html>
cmd> pub build example
Notice there is no packages/dart.js or interop.js
Change the pubspec from
dev_dependenciestodependencieset voila.For a library package that has
test/andexample/but no application, it should be recommended to havebrowserindev_dependenciesto avoid unnecessary constraints on the consumer of the package, so I believe this needs to be fixed in order forpub build testandpub build exampleto be useful.thanks
The text was updated successfully, but these errors were encountered: