Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polymer: Type error in file runner.dart in class BarbackOptions #15649

Closed
DartBot opened this issue Dec 16, 2013 · 6 comments
Closed

Polymer: Type error in file runner.dart in class BarbackOptions #15649

DartBot opened this issue Dec 16, 2013 · 6 comments
Assignees

Comments

@DartBot
Copy link

DartBot commented Dec 16, 2013

This issue was originally filed by dylan.kyle.p...@gmail.com


https://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/pkg/polymer/lib/src/build/runner.dart

/** Collects different parameters needed to configure and run barback. /
class BarbackOptions {
  /
* Other code **/

  /**
   * Whether to print error messages using a json-format that tools, such as the
   * Dart Editor, can process.
   */
  final String machineFormat;

  BarbackOptions(this.phases, this.outDir, {currentPackage, packageDirs,
      this.transformTests: false, this.transformPolymerDependencies: false,
      this.machineFormat: false})
      : currentPackage = (currentPackage != null
          ? currentPackage : readCurrentPackageFromPubspec()),
        packageDirs = (packageDirs != null
          ? packageDirs : _readPackageDirsFromPub(currentPackage));

}

In this code block, it can be obviously seen that machineFormat is of type String, but the default value given in the constructor is a value of false (obviously not a string type). This error keeps popping up when running my build.dart

@lrhn
Copy link
Member

lrhn commented Dec 16, 2013

Added Area-Pkg, Library-Polymer labels.

@lrhn
Copy link
Member

lrhn commented Dec 16, 2013

Added Triaged label.

@sigmundch
Copy link
Member

Set owner to @sigmundch.
Removed Area-Pkg, Library-Polymer labels.
Added Area-Polymer, Library-PolymerBuild, Started labels.

@sigmundch
Copy link
Member

thanks for pointing this out! - Sent fix (and added tests) here: https://codereview.chromium.org/106083005

@sigmundch
Copy link
Member

fixed and released in polymer-0.9.3+1


Added Fixed label.

@DartBot
Copy link
Author

DartBot commented Dec 16, 2013

This comment was originally written by dylan.kyle.p...@gmail.com


Thanks :)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants