Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dart editor syntax colors path as a reserved word when listed in #15328

Closed
DartBot opened this issue Nov 26, 2013 · 5 comments
Closed

Dart editor syntax colors path as a reserved word when listed in #15328

DartBot opened this issue Nov 26, 2013 · 5 comments
Assignees
@keertip
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue
Milestone
1.4

Comments

@DartBot
Copy link

DartBot commented Nov 26, 2013

This issue was originally filed by gruyere.emmen...@gmail.com

What steps will reproduce the problem?

  1. In the editor, add path to dependencies.
  2. The editor syntax colors path to look like a reserved word.

What is the expected output? What do you see instead? path is in same color as name, description, dependencies
name: poc
description: Proof of Concept
dependencies:
  route : any
  path : any

What version of the product are you using? On what operating system?
Dart Editor version 1.0.0_r30338 (DEV)
Dart SDK version 1.0.0.7_r30338
@DartBot
Copy link
Author

DartBot commented Nov 26, 2013

This comment was originally written by gruyere.emmen...@gmail.com

What is the expected output?

Path should be syntax highlighted only when it is a mapping underneath a dependency. so that:
dependencies:
  transmogrify:
    path: /Users/me/transmogrify

will syntax highlight path

dependencies:
  transmogrify: any
  path: any

will NOT syntax highlight path

@iposva-google
Copy link
Contributor

Added Area-Editor, Triaged labels.

@clayberg
Copy link

Set owner to @keertip.
Added this to the Later milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@clayberg
Copy link

clayberg commented Apr 9, 2014

Removed this from the Later milestone.
Added this to the 1.4 milestone.

@keertip
Copy link
Contributor

keertip commented Apr 11, 2014

This requires a bit of work and logic to be added to the pubspec editor. 'path' is the only reserved word that is used as a package name.

Added WontFix label.

@DartBot DartBot added this to the 1.4 milestone Apr 11, 2014
@kevmoo kevmoo added closed-not-planned Closed as we don't intend to take action on the reported issue and removed resolution-wont_fix labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keertip keertip

Labels
closed-not-planned Closed as we don't intend to take action on the reported issue
Projects
None yet
Milestone
1.4
Development

No branches or pull requests
5 participants
@kevmoo @keertip @iposva-google @clayberg @DartBot