Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RtcPeerConnection.addIceCandidate results in a NotSupportedError: Internal Dartium Exception (WebRTC/Dartium) #15008

Closed
DartBot opened this issue Nov 11, 2013 · 14 comments
Assignees
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@DartBot
Copy link

DartBot commented Nov 11, 2013

This issue was originally filed by @busybeaver


While working with Dart and WebRTC,

The following code will result in a "NotSupportedError: Internal Dartium Exception" in Darium but works fine in Chrome/dart2j:

RtcPeerConnection peer1 = new RtcPeerConnection(/.../);
RtcPeerConnection peer2 = new RtcPeerConnection(/.../);
peer1.onIceCandidate.listen((RtcIceCandidateEvent e) {
  if (e.candidate != null) {
    peer2.addIceCandidate(e.candidate, () => print('void: $e'), (var x) => print('FailureCallback: $e'));
  }
});

I also attached a very simple WebRTC example. Just create a new Dart web application and use the webrtctest.dart file.

The expected output (as seen in Chrome) is a "first text message over RTP data ports" console message. It seems like I'm not the only one with this problem: http://stackoverflow.com/q/19896137

Also, it seems odd that a public method like 'addIceCandidate' uses as last parameter a private "_RtcErrorCallback" object: http://api.dartlang.org/docs/releases/latest/dart_html/RtcPeerConnection.html#addIceCandidate

Below the information about Chrome, Dartium, and the operation system...

Dartium Version Stats:

Chromium 31.0.1650.39 (Developer Build 1593)
OS Mac OS X
Blink 537.36 (@­1589)
JavaScript V8 3.21.18.2
Dart 0.8.10.10_r30104
Flash 11.9.900.117
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.39 (Dart) Safari/537.36
Command Line /Applications/dart/chromium/Chromium.app/Contents/MacOS/Chromium --remote-debugging-port=59951 --user-data-dir=/Users//.dartium --enable-experimental-webkit-features --enable-devtools-experiments --no-first-run --no-default-browser-check --no-process-singleton-dialog --flag-switches-begin --flag-switches-end chrome://version/
Executable Path /Applications/dart/chromium/Chromium.app/Contents/MacOS/Chromium
Profile Path /Users/
/.dartium/Default

Chrome Version Stats:

Google Chrome 30.0.1599.101 (Official Build 227552)
OS Mac OS X
Blink 537.36 (@­159105)
JavaScript V8 3.20.17.15
Flash 11.9.900.117
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.0.1599.101 Safari/537.36
Command Line /Applications/Google Chrome.app/Contents/MacOS/Google Chrome -psn_0_7300854 --flag-switches-begin --enable-accelerated-filters --no-pings --flag-switches-end
Executable Path /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
Profile Path /Users/***/Library/Application Support/Google/Chrome/Default

OS:

Darwin ***.de 11.4.2 Darwin Kernel Version 11.4.2: Thu Aug 23 16:25:48 PDT 2012; root:xnu-1699.32.7~1/RELEASE_X86_64 x86_64


Attachment:
webrtctest.dart (2.46 KB)

@vsmenon
Copy link
Member

vsmenon commented Nov 14, 2013

Set owner to @a-siva.
Added this to the M9 milestone.

@vsmenon
Copy link
Member

vsmenon commented Nov 14, 2013

Removed this from the M9 milestone.
Added this to the 1.1 milestone.

@DartBot
Copy link
Author

DartBot commented Nov 27, 2013

This comment was originally written by chris.hotz.beho...@gmail.com


I have the same problem here. No solution found so far :/

@sethladd
Copy link
Contributor

sethladd commented Dec 9, 2013

@DartBot
Copy link
Author

DartBot commented Dec 31, 2013

This comment was originally written by igor.ko...@mailvision.com


1.1.0-dev.5.0 not fixed.

@DartBot
Copy link
Author

DartBot commented Jan 1, 2014

This comment was originally written by igor.ko...@mailvision.com


dart library try to call
  peerConnection.addIceCandidate(candidate, onsuccess , onerror);
that correct according http://www.w3.org/TR/webrtc/, but did not work.

Actually currently in Chrome (in javascript) implemented only obsolete version: peerConnection.addIceCandidate(candidate).

So fix seems trivial, check Chrome version and call addIceCandidate with or without
callbacks according the version.
(currently without callbacks, when Chrome developers add the callbacks to the
method, call it with callbacks)

@DartBot
Copy link
Author

DartBot commented Jan 24, 2014

This comment was originally written by Diede...@gmail.com


1.2.0-dev.1.0 still not fixed, I think "_RtcErrorCallback" should not be private and be more like this: http://www.w3.org/TR/webrtc/#idl-def-RTCPeerConnectionErrorCallback, hope it helps...

@sethladd
Copy link
Contributor

Removed this from the 1.1 milestone.
Added this to the 1.2 milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@vsmenon
Copy link
Member

vsmenon commented Feb 27, 2014

Removed this from the 1.2 milestone.
Added this to the 1.3 milestone.

@vsmenon
Copy link
Member

vsmenon commented Jun 4, 2014

Issue #15461 has been merged into this issue.

@vsmenon
Copy link
Member

vsmenon commented Jun 4, 2014

Removed this from the 1.3 milestone.
Added this to the 1.5 milestone.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the 1.5 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

7 participants