Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polymer.dart and Polymer.js cannot coexist #14098

Closed
blois opened this issue Oct 14, 2013 · 6 comments
Closed

Polymer.dart and Polymer.js cannot coexist #14098

blois opened this issue Oct 14, 2013 · 6 comments
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone

Comments

@blois
Copy link
Contributor

blois commented Oct 14, 2013

Both libraries do document.register('polymer-element'), but an element can only be registered once, so they conflict.

Dart should either piggy-back off of polymer.js or find the declarations without registering polymer-element.

@sigmundch
Copy link
Member

Removed this from the Later milestone.
Added this to the M9 milestone.

@clayberg
Copy link

Removed this from the M9 milestone.
Added this to the 1.1 milestone.

@jmesserly
Copy link

We can certainly work without the custom element, it's just a little strange if it's not registered. Finding the polymer-element is (currently) a viable way of reflecting on what the custom element can do. And it's kind of neat that the declaration just is the polymer-element.

The easiest fix would be a level of indirection: PolymerDeclaration is no longer a custom element; instead it points at the polymer-element. At that point, we can just leave the polymer-element as whatever it is (either HtmlElement or an upgraded JS custom element).

One of the problems is cases where we haven't seen the PolymerElement yet. Polymer.js delays registration. What we could do here is delay finding polymer-element until your custom-element is created.

But still, finding it would be tricky (linked documents) and add overhead.

I wonder if we can go with a hybrid approach -- if polymer.js is loaded, we do the more expensive search, otherwise we install our own polymer-element that notifies us when it's created so we can remember the association and hook up the element faster.

@sigmundch
Copy link
Member

Removed this from the 1.1 milestone.
Added this to the 1.2 milestone.

@sigmundch
Copy link
Member

Added Library-Polymer label.

@jmesserly
Copy link

fixed a while ago in 0.10.x


Added Fixed label.

@blois blois added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures labels May 14, 2014
@blois blois added this to the 1.2 milestone May 14, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

4 participants