Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Dartium expiration time / message #13312

Closed
vsmenon opened this issue Sep 13, 2013 · 11 comments
Closed

Adjust Dartium expiration time / message #13312

vsmenon opened this issue Sep 13, 2013 · 11 comments
Assignees
Labels
P0 A serious issue requiring immediate resolution
Milestone

Comments

@vsmenon
Copy link
Member

vsmenon commented Sep 13, 2013

We should lengthen Dartium's expiration to something longer to match stable Dart SDK / editor releases.

Ideally,

  • Have a popup warning after N weeks
  • Hard expiration after N+~2 weeks
@ricowind
Copy link
Contributor

Please let N be sufficiently high that conservative users (i.e., users that don't update their toolchain that often) don't get hit. Additionally, as discussed offline, how about a flag to suppress the warning?

@vsmenon
Copy link
Member Author

vsmenon commented Sep 16, 2013

Here's the bug to suppress:

https://code.google.com/p/dart/issues/detail?id=11500

@a-siva
Copy link
Contributor

a-siva commented Sep 18, 2013

Issue #11500 has been merged into this issue.

@vsmenon
Copy link
Member Author

vsmenon commented Oct 2, 2013

Removed this from the M7 milestone.
Added this to the M8 milestone.

@dgrove
Copy link
Contributor

dgrove commented Oct 17, 2013

We need to do this before M8.


Removed Priority-Unassigned label.
Added Priority-Critical label.

@vsmenon
Copy link
Member Author

vsmenon commented Oct 18, 2013

I'll make this 12 weeks.


Set owner to @vsmenon.
Added Accepted label.

@ricowind
Copy link
Contributor

How about a flag to suppress the expiration?

@vsmenon
Copy link
Member Author

vsmenon commented Oct 18, 2013

These have been landed:

CL for env variable (note, we'll move all env vars to flags at some later point): https://chromiumcodereview.appspot.com/29503002/
CL for 12 weeks: https://chromiumcodereview.appspot.com/29123003/


Added Fixed label.

@dgrove
Copy link
Contributor

dgrove commented Oct 21, 2013

reopen since https://chromiumcodereview.appspot.com/29503002/ was reverted.


Added Triaged label.

@vsmenon
Copy link
Member Author

vsmenon commented Oct 21, 2013

Added Accepted label.

@vsmenon
Copy link
Member Author

vsmenon commented Oct 24, 2013

Verified that this builds and works on Windows as well.


Added Fixed label.

@vsmenon vsmenon added Type-Defect P0 A serious issue requiring immediate resolution labels Oct 24, 2013
@vsmenon vsmenon self-assigned this Oct 24, 2013
@vsmenon vsmenon added this to the M8 milestone Oct 24, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 A serious issue requiring immediate resolution
Projects
None yet
Development

No branches or pull requests

4 participants