Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/unittest: test cases should be run in zones #13277

Closed
kevmoo opened this issue Sep 12, 2013 · 12 comments
Closed

pkg/unittest: test cases should be run in zones #13277

kevmoo opened this issue Sep 12, 2013 · 12 comments
Assignees
@kevmoo
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. type-enhancement A request for a change that isn't a bug

Comments

@kevmoo
Copy link
Member

kevmoo commented Sep 12, 2013

If each test case had its own Zone, then it would be straightforward to send async errors to the correct test case.

In theory, this could eliminate (or at least minimize) the use of guardAsync and handleExternalError
@floitschG
Copy link
Contributor

Yes.
I think we should tests in their individual zones, once they are done.

@kevmoo
Copy link
Member Author

kevmoo commented Sep 16, 2013

Marked this as being blocked by #13334.

@kevmoo
Copy link
Member Author

kevmoo commented Sep 16, 2013

Marked this as being blocked by #11279.
Unmarked this as being blocked by #13334.

@dgrove
Copy link
Contributor

dgrove commented Sep 17, 2013

Added Triaged label.

@floitschG
Copy link
Contributor

Issue #10150 has been merged into this issue.

cc @gramster.
cc @justinfagnani.

@kevmoo
Copy link
Member Author

kevmoo commented Feb 4, 2014

Committed https://code.google.com/p/dart/source/detail?r=32284
...and reverted: https://code.google.com/p/dart/source/detail?r=32288

Stay tuned

Set owner to @kevmoo.

@kevmoo
Copy link
Member Author

kevmoo commented Feb 5, 2014

Marked this as being blocked by #16541.

@kevmoo
Copy link
Member Author

kevmoo commented Feb 6, 2014

https://codereview.chromium.org/133313004/

@kevmoo
Copy link
Member Author

kevmoo commented Feb 7, 2014

r32400

Added Fixed label.

@kevmoo
Copy link
Member Author

kevmoo commented Feb 12, 2014

Added Pkg-Unittest label.

@kevmoo
Copy link
Member Author

kevmoo commented Feb 12, 2014

Removed Area-UnitTest label.
Added Area-Pkg label.

@kevmoo kevmoo added Type-Enhancement area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Feb 12, 2014
@kevmoo kevmoo self-assigned this Feb 12, 2014
This was referenced Jun 3, 2015
Closed
Closed
Closed
Closed
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/test#228.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed priority-unassigned labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevmoo kevmoo

Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @dgrove @floitschG @DartBot