Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/install/git/dependency_name_match_pubspec_test failing consistently #10348

Closed
ricowind opened this issue May 1, 2013 · 7 comments
Closed

test/install/git/dependency_name_match_pubspec_test failing consistently #10348

ricowind opened this issue May 1, 2013 · 7 comments
Assignees
@sgjesse
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-cannot-reproduce Closed as we were unable to reproduce the reported issue library-io P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone
M5

Comments

@ricowind
Copy link
Contributor

ricowind commented May 1, 2013

This started failing on windows after Srdjan fixed vm bug for no such method.
Started failing in:
http://build.chromium.org/p/client.dart/builders/pub-win/builds/6495

I will suppress in status file
@ricowind
Copy link
Contributor Author

ricowind commented May 1, 2013

This is passing on russian locale, but failing on en locale.

Marking as skip in status file, updating priority since we are loosing coverage

Removed Priority-Medium label.
Added Priority-High label.

@ricowind
Copy link
Contributor Author

ricowind commented May 1, 2013

Marked this as flaky instead so that you guys can see output in the flaky log

@munificent
Copy link
Member

Added this to the M5 milestone.

@munificent
Copy link
Member

Added Started label.

@munificent
Copy link
Member

I tried locally and it seemed to work fine, so I've re-enabled this. If it happens again, we can re-open this bug. The failure is here:

  | Expected stderr to match "^The name you specified for your dependency, "weirdname", doesn't match the name "foo" in its pubspec." but got:
  | | type 'int' is not a subtype of type 'Uint8List' of 'source'.
  | | #­0 _makeUint8ListView (dart:io-patch:75:40)
  | | #­1 _RandomAccessFile._read (dart:io-patch:65:3)
  | | #­2 _RandomAccessFile.readSync (dart:io:1293:23)
  | | #­3 _File.readAsBytesSync (dart:io:1127:34)
  | | #­4 _File.readAsStringSync (dart:io:1142:41)
  | | #­5 readTextFile (file:///E:/b/build/slave/pub-win/build/dart/sdk/lib/_internal/pub/lib/src/io.dart:45:36)

That stack trace is in the bowels of dart:io, so this is unlikely to be a pub issue.

Removed Area-Pub label.
Added Area-IO, CannotReproduce labels.

@madsager
Copy link
Contributor

madsager commented May 2, 2013

That looks like a checked mode warning, we should check.

Set owner to @sgjesse.

@kevmoo
Copy link
Member

kevmoo commented May 14, 2014

Removed Area-IO label.
Added Area-Library, Library-IO labels.

@ricowind ricowind added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io closed-cannot-reproduce Closed as we were unable to reproduce the reported issue labels May 14, 2014
@ricowind ricowind added this to the M5 milestone May 14, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgjesse sgjesse

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-cannot-reproduce Closed as we were unable to reproduce the reported issue library-io P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
M5
Development

No branches or pull requests
5 participants
@kevmoo @munificent @sgjesse @madsager @ricowind