Replace posix strdup with c standard strlen/malloc/memcpy #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On MSVC the strdup implmentation differs from the posix version causing a heap violation error when the resulting string is freed.
|
@Lego3 would you mind to look at this and see if it fixes your heap errors. You were saying on irc you couldn't run in debug mode in visual studio with luaJIT. With this patch it works for me. |
|
Sure, I will try it out in a few days. |
|
It still doesn't work for me. Then again I'm not entirely sure I do everything correctly either... |
|
@Lego3 Do you still get a heap error? If so could you post the stack trace in a new issue? |
Lego3
added a commit
that referenced
this pull request
Dec 28, 2014
Replace posix strdup with c standard strlen/malloc/memcpy
|
I had a deeper look at this, and I can confirm that your changes solved that particular part of my problem. The reason it still doesn't work for me is that I now get roughly the same error in the call to Mix_LoadWAV_RW in THSoundEffects::setSoundArchive. If I disable sound in cmake it works fine now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MSVC the strdup implmentation differs from the posix version causing a heap violation error when the resulting string is freed when CorsixTH is run in debug (at least on MSVC 2010)