Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load savegame menu tooltip placements #1651

Merged
merged 1 commit into from Jun 23, 2020

Conversation

tobylane
Copy link
Member

Fixes #518
Are the variable names ok?

@TheCycoONE
Copy link
Member

Not the worst.

@lewri
Copy link
Member

lewri commented Jun 20, 2020

I imagine the 1x and 2x and y refer to axis/position. I think making that more obvious like button_1x, button_2x, button_y is better?
Edit: Or if it's two separate buttons, maybe button1_x and button2_x

@TheCycoONE
Copy link
Member

It's really fine as is for UI code.

@TheCycoONE TheCycoONE merged commit 9c9962a into CorsixTH:master Jun 23, 2020
@lewri lewri added this to Done in 0.65 Release Jul 13, 2020
@tobylane tobylane deleted the savemenu branch April 28, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
0.65 Release
  
Done
Development

Successfully merging this pull request may close these issues.

Load game window Tooltip-bug: wrong place
3 participants