[RDY] Support more audio formats for background music #1364
Conversation
CorsixTH/Lua/config_finder.lua
Outdated
| -- (MIDI) audio, then follow these steps: | ||
| -- 1) Find MP3 versions of the original tracks (for example the remixes by ZR | ||
| -- If you want to listen to non-Theme-Hospital music, then follow these steps: | ||
| -- 1) Find updated versions of the original tracks (for example the remixes by ZR | ||
| -- from http://www.a-base.dds.nl/temp/ThemeHospital_ZRRemix.zip ) or any | ||
| -- other music you want to listen to. | ||
| -- 2) Ensure that SMPEG.dll (or equivalent for your platform) is present. |
There was a problem hiding this comment.
SMPEG.dll is not used on any platform anymore, and different libraries are needed for different sound formats. This comment should be generalized.
There was a problem hiding this comment.
Actually remove that line completely. This is for end users, and we will ship with all relevant libraries.
WindowsInstaller/config_template.txt
Outdated
| -- High quality (MP3 rather than MIDI) audio replacements. | ||
| -- If you want to listen to high quality MP3 audio rather than the original XMI | ||
| -- (MIDI) audio, then follow these steps: | ||
| -- If you want to listen to non-Theme-Hospital music, then follow these steps: | ||
| -- 1) Find MP3 versions of the original tracks (for example the remixes by ZR |
There was a problem hiding this comment.
MP3 comment here needs to be generalized for more music formats
There was a problem hiding this comment.
Remove the comment about SMPEG here; this is meant for end users, and we will ship with every relevant library.
|
The third comment removes a persistable function. I haven't done this before, is there something extra in removing them, or is that only for functions in a savegame? |
|
Normally you can't remove persistable functions, but that one is outside of any possible save, so I'm not sure why it was marked that way in the first place. If your save games load, it should be good. |
|
What's the state of this @tobylane |
|
I've removed the other commit and rebased. Ready now. |
tobylane
changed the title
|
Tested 👍 |
This plays major file types from this sdl2_mixer page, others could be added. I'm not sure on the names waveform and instructional.
The support that the second commit talks about is broad, for me it's
brew install libvorbis; brew reinstall sdl2_mixer --with-mpg123 --with-flac --with-libmikmod --with-fluid-synth. The equivalent could be done for the deps repo.Fixes #540 and #821.