Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

--nojsdoc option is broken in 2.3.10 #64

Closed
GoogleCodeExporter opened this issue Jun 17, 2015 · 6 comments
Closed

--nojsdoc option is broken in 2.3.10 #64

GoogleCodeExporter opened this issue Jun 17, 2015 · 6 comments
Labels
auto-migrated Priority-Medium Type-Defect

Comments

@GoogleCodeExporter
Copy link 

Even if you set --nojsdoc, closure-linter will still report those errors.

See https://travis-ci.org/mozilla-b2g/gaia/builds/7043293 for one example of 
doc errors being reported.

Original issue reported on code.google.com by rik...@gmail.com on 10 May 2013 at 10:33
@GoogleCodeExporter
Copy link
Author 

Confirmed
After upgrading my node wrapper[1], my test are broken

Meanwhile this is fixed, you can use the following flag
--disable 220

[1] https://github.com/jmendiara/node-closure-linter-wrapper

Original comment by jmendi...@gmail.com on 15 May 2013 at 2:03

@GoogleCodeExporter
Copy link
Author 

It seems some parenthesis are missing in errorrules.py

PATCH:
find:
errors.MISSING_JSDOC_TAG_THIS)) and 
          not FLAGS.disable or error not in disabled_error_nums)

replace with:
errors.MISSING_JSDOC_TAG_THIS)) and (
          not FLAGS.disable or error not in disabled_error_nums))

Original comment by jmendi...@gmail.com on 15 May 2013 at 2:24

@GoogleCodeExporter
Copy link
Author 

could we fix this please ?

Original comment by fel...@gmail.com on 21 Jun 2013 at 1:23

@GoogleCodeExporter
Copy link
Author 

Here's the patch, fixes the problem for me.

Original comment by fel...@gmail.com on 21 Jun 2013 at 1:26

Attachments:

@GoogleCodeExporter
Copy link
Author 

I'll handle this one.

Original comment by vagra...@google.com on 29 Jul 2013 at 5:38

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

Original comment by vagra...@google.com on 29 Jul 2013 at 5:30

  • Changed state: Fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
auto-migrated Priority-Medium Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter