You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
http://build.chromium.org/p/chromium.fyi/builders/Cr%20Win%20Clang/builds/108/steps/compile/logs/stdio
..\..\third_party\cld_2\src\internal\offsetmap.cc(82,43) : warning(clang): format
specifies type 'long' but the argument has type 'size_type' (aka 'unsigned int') [-Wformat]
fprintf(fout, "Offsetmap: %ld bytes\n", diffs_.size());
~~~ ^~~~~~~~~~~~~
%u
There's no great portable way to printf size_t types. Since this is debugging code,
I suggest this patch:
Nicos-MacBook-Pro:src thakis$ svn diff
Index: internal/offsetmap.cc
===================================================================
--- internal/offsetmap.cc (revision 165)
+++ internal/offsetmap.cc (working copy)
@@ -79,7 +79,8 @@
}
Flush(); // Make sure any pending entry gets printed
- fprintf(fout, "Offsetmap: %ld bytes\n", diffs_.size());
+ fprintf(fout, "Offsetmap: %lu bytes\n",
+ static_cast<unsigned long>(diffs_.size()));
for (int i = 0; i < static_cast<int>(diffs_.size()); ++i) {
fprintf(fout, "%c%02d ", "&=+-"[OpPart(diffs_[i])], LenPart(diffs_[i]));
if ((i % 20) == 19) {fprintf(fout, "\n");}
Can you land this, please?
Reported by thakis@chromium.org on 2014-08-18 14:24:33
The text was updated successfully, but these errors were encountered:
Originally reported on Google Code with ID 21
Reported by
thakis@chromium.org
on 2014-08-18 14:24:33The text was updated successfully, but these errors were encountered: