IssueTracker

I was able to solve it with a custom LinearLayoutManager.  It would be nice for the LinearLayoutManager to act this way by default but is not a RecyclerView defect.

Hi obsidianx, what does your workaround look like, just ran into the same issue :(

I borrowed the solution from the LeanBack source code in GridLayoutManager.java.  Basically in onMeasure of the LayoutManager you check to see if you have any children in your layout yet and if not then have the associated RecyclerView build one for you so you can measure it.

Look at GridLayoutManager.measureScrapChild(...)  to see what I'm talking about (<sdk>/extras/android/m2repository/com/android/support/leanback-v17/21.0.0-rc1/leanback-v17-21.0.0-rc1-sources.jar).  This particular solution for measurement works best if all of the child views are the same width/height depending on orientation.

Could you post your code to your custom layout manager?

[Comment deleted]

Attached is a custom LayoutManager based on obsidianx's suggestions which worked for me.

The solution will work for fixed items provided in adapter. If the items are dynamically added/removed from the adapter then it will not work. For dynamically added items the onMeasure phase fires before any items are added in the view and hence the calculated height is returned as zero.

You're right.  I had to initialize the adapter with one dummy item so that the initial measuring could work.  Then, later, after re-setting the adapter with the real set of (dynamically obtained) items, the recycler view was (somehow) still properly sized, without me needing to do anything.  

Check my improved solution: http://stackoverflow.com/a/27616854/1016367
Works good with dynamically changed data in adapter and with zero items adapter too.

We really need proper "wrap_content" support in the official layout managers. Can we expect this to come any time soon?

Why is this priority-small? Really, this should be a big focus, since RecylclerView is advertised everywhere and seems to be the perfect solution.
This makes layouts really defect, having dialogs strech over the full screen and making the intended use of Dialogs really to nonsense.

Did not find even a workaround yet. With the solution above there are no item decorations and if the list goes beyond the current screen size just all the elements disappear.

Is it the reason for this ? http://stackoverflow.com/questions/29469377/recyclerview-strange-scrolling-when-dataset-changed

I also have this problem however when I use the solutions given here and from StackOverflow my onBindViewHolder() gets spammed instead. It seems it's called for every item in the list, every time measureScrapChild() is called (so in my case 11 items -> 88 calls). This is a problem for me since I try to load images async when binding. Anyone have an idea on how to solve this?

Here is my version of LinearLayoutManager which supports WRAP_CONTENT: https://github.com/serso/android-linear-layout-manager/blob/master/lib/src/main/java/org/solovyev/android/views/llm/LinearLayoutManager.java
I tried to fix the problems previously suggested solutions have. Note that the problem still should be solved by SDK itself as there is no way of getting information about dimensions of children when RecyclerView is animating.

Wrapped nicely in the library: https://github.com/serso/android-linear-layout-manager

This causes all sorts of problems, and should not be considered a "small defect".

Has anyone a fixed GridLayoutManager? I'm an not so skilled android developer, to fix it myself.

It's a shame this has already almost 1 year without a fix...
No wrap_content available for a master piece in the new Material Design pattern, Google do you think this is normal?? no way

Still not fixed yet :(

This is actually really annoying without a fix. Come on Google.

Wow. It's been a year but this issue is still not fixed.

The github code from #15 finally works! Great job - thanks a bunch!

Just hit this issue too, scratching my head until I saw this ticket

This works for GridLayoutManager

So much abandonment. Same quality apps you'll see on the playstore

[Comment deleted]

When is this going to be fixed?

targeted for early 2016.

If I use any custom LinearLayoutManager I am facing issue with scrolling it freezes the app and anr is coming up.

[Comment deleted]

really google? small priority? this messes up the staggeredgridlayoutmanager too.

The CustomGridLayoutManager.txt  have a bug in calculating the height for the recyclerview when manager.setSpanSizeLookup(new WrappableGridLayoutManager.SpanSizeLookup() {
            @Override
            public int getSpanSize(int i) {
if(i == 0){
return 2
} else {
return 1
}
           }

I waited till this 2016..but its waste...not solution till...what is this

I waited till this 2016..but its waste...not solution till...what is this

Will the early 2016 solution work also for StaggeredGridLayoutManager?

Hi, I've bumped into this issue this week. First of all, thanks for whoever made that CustomGridLayoutManager available, saved me a lot of time. However, I've noticed a few shortcomings (to me, at least) that were not properly addressed in that class.

The main obstacle I noticed was that the class assumed the dimension of the first item was enough for all subsequent items, which is not the case when [i > 0] items are larger than the [i = 0] item. While it didn't actually crop the RecyclerView contents, it made it appear scrolling even when it should not (i.e., wrap_content with smaller size than the parent).

That said, I made some changes that better suited my case, commenting what I found adequate. It is tested (as far as I can think about use cases) with RecyclerView set to wrap_content and fixed size, which is what I need. I did not tested it (yet?) with max sizings or match_parent.

Link below.

https://gist.github.com/davidcesarino/7e85b5eee82307c06e08

Hope it helps, or at least gives any clue to someone who may be facing a similar challenge. Other than that, if you can help improve it, I'll be glad.

#36, you need to disable predictive animations if you do that, otherwise, it may crash in onMeasure when new items are added. (see docs for differences between State#itemCount  vs getItemCount).

Meanwhile, we are working on a generic solution where RecyclerView can do most of the work and also support predictive animations.

Thank you very much for your warning, as I'm still learning this.

@davidcesarino You have a small bug in your WrappedGridLayoutManager. You're adding rowMeasure on item in the last row column but last row may end before last column. Imagine grid 3x3 with 7 items. I suppose your line 84 should look like this

if (i % getSpanCount() == (getSpanCount() - 1) || i == state.getItemCount() - 1) {

You may want to fix that.

I don't think setting wrap_content to RecyclerView doesn't make much sense, just as it doesn't for ListView, because it can't know the size of all of the items without going through all of them, yet there can be tons of items (even infinite or close to it in some cases).

The sizes might even change.

Google even talks about this bad practice on its old video "the world of ListView". They said that ListView has a small trick to handle "wrap_content", to check only a few items, and assume all of the others are the same.

However, it could be nice to tell the RecyclerView to assume that all items are the same size (height in case of horizontal, width in case of vertical) and it will set its size automatically.

Maybe it's easy to do it via the onbindviewholder function call.

Hi , I have attached , Edit #7 betteri...@gmail.com , LayoutManager file (MyLinearLayoutManager.txt) for Horizontal RecyclerView , It's worked fine for me ...

Thanks  betteri...@gmail.com .

This has been merged into the internal tree, should be available with the next version of support library.

How will it be fixed? Will it just automatically work with height=wrap_content? Or will there be a new option on the layout manager? Or.... ?

We are introducing a new API called auto-measure where RecyclerView measures the Layout by calling LayoutManager#onLayout during an onMeasure call.
By controlling this flow, RecyclerView is able to track animations properly even if onMeasure is called multiple times.

This is an opt-in API and all default layout managers now use it to wrap their contents.
It is very easy for a LayoutManager to support the new API. For instance, for the LinearLayoutManager, it was only 27 lines of code change to support it (mostly calling it to enable and handling infinite layout case).
I'm hoping all external layout managers will move to this API but we are keeping the old API for the backward compatibility. The major benefit of the new API is that it can run predictive animations which was not possible w/ the old API.

Sounds great, thanks!

Awesome, thanks!

When will the change noted in #44 be available?

Any ETA on the changes?

[Comment deleted]

I took the Horizontal RecyclerView CustomLayoutManager from #41 and added the case where there might not be any children so you don't get an IndexOutOfBounds Exception.

Looking forward to the official release; can we get an ETA?

#39: Sorry I took so long to answer you. As said, I barely tested it at first and didn't account for that scenario (I use multiples of span count). Thank you and gist updated.

This issue drove us mad. All the custom LinearLayoutManagers did not work. An ETA on the fix would be really helpful.

it will be released soon. Sorry i cannot commit to a date but the branch is locked to only bugfixes.

Will this work for GridLayoutManagers as well? I have a solution for the LinearLayoutManager in place but the GridLayoutManager still produces problems.

yes. all built in layout managers will have this support.

Would this solve the issue for Wrap_Content in A StaggeredGridLayout Manager?

https://github.com/serso/android-linear-layout-manager solution not working for nested recyclerview if row layout has wrap_content height also CustomLayoutManager.java posted by few guys causes out of memory issue after scrolling multiple times up and down may I know how it is done in app like google play store there is horizontal recyclerview with wrap_content height.

When will be solution in support library will be available for this major issue.

I want to achieve something like attached in screen shot. I am using nested RecyclerView this but wrap_content on child is not working since there is issue as mentioned can anyone tell me how to achieve this

Released with 23.2. If you have issues with 23.2, please create separate tickets with sample apps to reproduce the issue.

also please check the RecyclerView section in the release notes:
http://android-developers.blogspot.com/2016/02/android-support-library-232.html

Worked for me! Thanks!

Finally, it fixed!

We love you Yigit 👏😍

Fixed one bug but another bug appeared
https://code.google.com/p/android/issues/detail?id=201791
http://stackoverflow.com/questions/35619022/nullpointerexception-in-dissapearence-animation-of-recyclerview-from-support-v-2

The issue is fixed now, but there is another issue:

In a framelayout a have the recyclerview as child of a cardview, the cardview has some margin, on portrait it works fine, but in landscape the bottom the card is not fully visible, its like 8dp of the bottom is cut off

UPDATE to my recyclerview landscape issue, if I touch the tab bar and scroll app, then I see the space like in portrait, but on portrait its fine

#65 thats not related to the RecyclerView. Your cardview  (which contains the RV) does not fit the screen.
To fix that. you should make your card view match_parent.

#64 please create another issue with steps to reproduce your problem.

#67 why it wouldn't fit its WRAP_CONTENT

because its children require more space then you have available.

#70 it didn't fix it by setting match_parent, also the issue is only on landscape not portrait, plz have a look:
https://code.google.com/p/android/issues/detail?id=201856

WRAP_CONTENT still doesn't work when the RecyclerView has no children...

#72, thanks, i can reproduce it and i've created an internal bug.

#72 will be fixed in the next release.

When removing a child and using animations for it, the wrap_content size is decreased before the animation finishes.

I just filled a ticket regarding nested scroll with wrap_content:

https://code.google.com/p/android/issues/detail?id=202216

#75 it is supposed to do that. RV's animation is controlled by its parent (as RV controls its children). See the release notes:
http://android-developers.blogspot.com/2016/02/android-support-library-232.html

"Note that although RecyclerView animates its children, it does not animate its own bounds changes. If you would like to animate the RecyclerView bounds as they change, you can use the Transition APIs."

"Note that although RecyclerView animates its children, it does not animate its own bounds changes. If you would like to animate the RecyclerView bounds as they change, you can use the Transition APIs."

Would love to see an example of this. Because RecyclerView changes its bounds on its own, I'm not sure how to utilize the transitions API to animate the change (while keeping recyclerview abstracted from the Transitions API)

sorry didn't have time to create a sample app but we'll do that.
TransitionAPI does not resize views. It always lets views decide their before and after sizes and animate between them. This is actually what RV does to its children except its logic is a bit different because RV is a collection.
We had a talk about this if interested:
https://www.youtube.com/watch?v=imsr8NrIAMs

one more thing, if you play with it, make sure you exclude RV's children from transition's targets.
http://developer.android.com/reference/android/transition/Transition.html
see addTarget, removeTarget methods.

I'm wanting to add a RecyclerView into a ScrollView so I can easily add a header to the RecyclerView.

I've called setAutoMeasureEnabled(true) to the LayoutManager but the result is no recycling of child views.

If there are 10,000 items in my adapter, 10,000 views are created...

Is this expected behaviour?

you should not put a RV inside a ScrollView because scrollview gives its children infinite space.
Unfortunately, you plan to use ScrollView and RV to implement headers cannot work. Instead, use a wrapper adapter.

That's a shame. Would of made adding a header much simpler!

Thanks for the clarification.

RecyclerView support for wrap_content does still have problem on animation. Refers to https://medium.com/@elye.project/recyclerview-supported-wrap-content-not-quite-f04a942ce624#.n7xivnrdr

that is WAI. Animating a child's bounds is the parent's responsibility.

I do not think this is working as intended. I do think this is a very difficult problem that nobody wants to deal with.

I have tried setting rv.setHasFixedSize(false); and now RecyclerView is getting adjusted based on its items.

email rmattison1@gmail.com I'll fix Google's implementation for you for $.

Up to now, the problem #1 isn't able to be fixed ? Horizontal RV does not "wrap_content" with height of item view base on its data.

Still not fixed same problem as described here: RecyclerView support for wrap_content does still have problem on animation. Refers to https://medium.com/@elye.project/recyclerview-supported-wrap-content-not-quite-f04a942ce624#.n7xivnrdr

Same issue, seems not fix by google using recyclerview1.2.1