RecyclerView 25.1.0 StaggeredGridLayoutManager GapWorker prefetch FC with full-span items [37130105]

Verified

Bug

[AOSP] assigned

[AOSP] Released

Status Update

No update yet.

Description

ta...@gmail.com

created issue #1

Dec 15, 2016 01:00AM

Library used (support-v4, appcompat-v7, ...): recyclerview-v7
Version used: 25.1.0
Theme used: Theme.AppCompat.Light.DarkActionBar
Devices/Android versions reproduced on: Android API 23 AVD emulator, Android 5.1 user devices

- Relevant code to trigger the issue.

https://github.com/talklittle/Support25.1.0FCStaggeredGridLayoutManagerPrefetch

The important parts of the code:

1. Uses StaggeredGridLayoutManager with multiple columns.
2. Some of the items are full span: `StaggeredGridLayoutManager.LayoutParams.setFullSpan(true)`
3. Call `RecyclerView.Adapter.notifyItemChanged()` on UI thread (e.g. post delayed Handler)

When running the example app, try flinging the RecyclerView up and down several times. It will eventually force close.

- Stack trace:

java.lang.IllegalArgumentException: Pixel distance must be non-negative
at android.support.v7.widget.GapWorker$LayoutPrefetchRegistryImpl.addPosition(GapWorker.java:110)
at android.support.v7.widget.StaggeredGridLayoutManager.collectAdjacentPrefetchPositions(StaggeredGridLayoutManager.java:2109)
at android.support.v7.widget.GapWorker$LayoutPrefetchRegistryImpl.collectPrefetchPositionsFromView(GapWorker.java:94)
at android.support.v7.widget.GapWorker.buildTaskList(GapWorker.java:213)
at android.support.v7.widget.GapWorker.prefetch(GapWorker.java:343)
at android.support.v7.widget.GapWorker.run(GapWorker.java:370)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:5417)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

Comments

am...@google.com <am...@google.com> Dec 15, 2016 07:25AM

Assigned to am...@google.com.

am...@google.com <am...@google.com> #2Dec 15, 2016 08:59AM

I am getting the same problem after the latest update...

yb...@google.com <yb...@google.com> Dec 15, 2016 04:55PM

Reassigned to cc...@android.com.

ta...@gmail.com <ta...@gmail.com> #3Dec 15, 2016 06:31PM

I think this might be the same as

issue 36949180

. As mentioned in the comments there, try:
As a temporary workaround, try turning off Preferences > Compiler > Use External Build.

am...@google.com <am...@google.com> #4Dec 21, 2016 04:52AM

Deleting the out folder before rebuilding solves the problem

go...@gmail.com <go...@gmail.com> #5Dec 23, 2016 10:43PM

turning off Preferences > Compiler > Use External Build doesn't work if you have other modules as dependencies.

Screen Shot 2016-12-24 at 03.41.10.png

951 KB

View

Download

Screen Shot 2016-12-24 at 03.41.09.png

1.1 MB

View

Download

Screen Shot 2016-12-24 at 03.41.08.png

1 MB

View

Download

Screen Shot 2016-12-24 at 03.40.48.png

944 KB

View

Download

Screen Shot 2016-12-24 at 03.41.03.png

888 KB

View

Download

Screen Shot 2016-12-24 at 03.41.05.png

1 MB

View

Download

Screen Shot 2016-12-24 at 03.41.06.png

1 MB

View

Download

go...@gmail.com <go...@gmail.com> #6Dec 24, 2016 10:02AM

I'm having the same problem.

yb...@google.com <yb...@google.com> #7Dec 24, 2016 08:10PM

Status: Won't Fix (Intended Behavior)

Same issue here

ta...@gmail.com <ta...@gmail.com> #8Dec 24, 2016 11:30PM

Also having this problem, but turning off Preferences > Compiler > Use External Build worked for me, even though I have other modules as dependencies, despite what jai.chan mentioned.

yb...@google.com <yb...@google.com> #9Dec 25, 2016 07:58AM

Status: Assigned (reopened)

[Comment deleted]

pr...@gmail.com <pr...@gmail.com> #10Jan 17, 2017 10:28AM

Problem exists. Turning off "Use external build" helps.

yb...@google.com <yb...@google.com> #11Jan 17, 2017 04:01PM

Also having the same problem.But I don't know How can I fix ?

jo...@gmail.com <jo...@gmail.com> #12Jan 18, 2017 09:16AM

The problem is still there... :s

st...@googlemail.com <st...@googlemail.com> #13Jan 24, 2017 02:48PM

having the same issue here too

am...@google.com <am...@google.com> #14Feb 1, 2017 05:34AM

Marked as fixed.

Still happens

ta...@gmail.com <ta...@gmail.com> #15Feb 9, 2017 03:55AM

A shame that google is not able to solve this issue since several years but is able to pop out yet another android version.

sk...@googlemail.com <sk...@googlemail.com> #16Feb 9, 2017 12:39PM

Android Studio 1.4 and this or similar bug is still here! My project is completely blocked due to inability to add a new activity class without getting "cannot find symbol" for it. The other classes are getting compiled except that activty. I've checked in the build/intermediates/classes - the activity .class is missing, not even compiled though it is hollow class, no syntax error.

Already tried:
Invalidate Cache and Restart - nope
Deleted /build directory and rebuild - nope
./gradlew clean of entire project - nope
Restarting after everything above - nope
Recreating a new blank activity - nope
Checked manifest entries for the activity - nope
Combination of the above - nope

Desperation mode: on

cc...@android.com <cc...@android.com> #17Feb 9, 2017 02:56PM

Status: Assigned (reopened)

I've just managed to workaround it! Simple Refactor > Move to another package did remove the error, but after I moved it back to the original package the error appeared again. Have NO idea what's going on!

[Deleted User] <[Deleted User]> #18Feb 16, 2017 03:30AM

Damn, I've found that class in the long forgotten exclude list in my build.gradle! What a stupid mistake of mine. Mystery revealed! (chuckle)

cc...@android.com <cc...@android.com> #19Feb 16, 2017 07:05PM

#19 and #21 are slightly different from the original issue, since they're from LinearLayoutManager and GridLayoutManager. I see how this may be occurring, and will put in a fix.

As to the case in #18, I'm not sure how StaggeredGridLayoutManager could have these issues in 25.1.1, looking at the code (and scrolling around manually in a 2 column staggered grid), I'm not seeing the issue. Are you sure you're both on 25.1.1, and seeing StaggeredGridLayoutManager in the stack trace?

bf...@gmail.com <bf...@gmail.com> #20Feb 20, 2017 06:15AM

Getting the same stacktrace with RecyclerView for support library 25.1.1

Fatal Exception: java.lang.IllegalArgumentException: Pixel distance must be non-negative
at android.support.v7.widget.GapWorker$LayoutPrefetchRegistryImpl.addPosition(GapWorker.java:110)
at android.support.v7.widget.LinearLayoutManager.collectPrefetchPositionsForLayoutState(LinearLayoutManager.java:1202)
at android.support.v7.widget.LinearLayoutManager.collectAdjacentPrefetchPositions(LinearLayoutManager.java:1300)
at android.support.v7.widget.GapWorker$LayoutPrefetchRegistryImpl.collectPrefetchPositionsFromView(GapWorker.java:94)
at android.support.v7.widget.GapWorker.buildTaskList(GapWorker.java:213)
at android.support.v7.widget.GapWorker.prefetch(GapWorker.java:343)
at android.support.v7.widget.GapWorker.run(GapWorker.java:370)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6119)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

yu...@gmail.com <yu...@gmail.com> #21Feb 20, 2017 02:19PM

[Comment deleted]

em...@gmail.com <em...@gmail.com> #22Feb 27, 2017 06:52PM

I have the same crash using support lib 25.2.0. Is there a different issue to track this crash from a LinearLayoutManager, looks like it was opened for the StaggeredGridLayoutManager

Pixel distance must be non-negative
java.lang.IllegalArgumentException: Pixel distance must be non-negative
at android.support.v7.widget.GapWorker$LayoutPrefetchRegistryImpl.addPosition(GapWorker.java:110)
at android.support.v7.widget.LinearLayoutManager.collectPrefetchPositionsForLayoutState(LinearLayoutManager.java:1202)
at android.support.v7.widget.LinearLayoutManager.collectAdjacentPrefetchPositions(LinearLayoutManager.java:1300)
at android.support.v7.widget.GapWorker$LayoutPrefetchRegistryImpl.collectPrefetchPositionsFromView(GapWorker.java:94)
at android.support.v7.widget.GapWorker.buildTaskList(GapWorker.java:213)
at android.support.v7.widget.GapWorker.prefetch(GapWorker.java:343)
at android.support.v7.widget.GapWorker.run(GapWorker.java:370)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6119)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

xl...@gmail.com <xl...@gmail.com> #23Mar 6, 2017 12:17PM

got the same crash with 25.1.1 annd 25.2.0.

here you can find the demo project to reproduce this issue:

https://github.com/longerian/VlayoutDemo

bf...@gmail.com <bf...@gmail.com> #24Mar 7, 2017 01:24PM

Faced the same issue with 25.1.1. Fixed it using
StaggeredGridLayoutManager.setItemPrefetchEnabled(false);
or
LinearLayoutManager.setItemPrefetchEnabled(false);

xl...@gmail.com <xl...@gmail.com> #25Mar 8, 2017 08:21AM

update demo project to reproduce this issue

https://github.com/QuincySx/VlayoutDemo

am...@google.com <am...@google.com> #26Apr 27, 2017 09:11AM

Verified by am...@google.com.

The issue is fixed in latest support libraries. If you come across the issue again, please let us know by raising a new issue along with the sample code which reproduces the issue.
Thanks.

Issue 37130105

Description

Issue summary

Comments

am...@google.com <am...@google.com> Dec 15, 2016 07:25AM

am...@google.com <am...@google.com> #2Dec 15, 2016 08:59AM

yb...@google.com <yb...@google.com> Dec 15, 2016 04:55PM

ta...@gmail.com <ta...@gmail.com> #3Dec 15, 2016 06:31PM

am...@google.com <am...@google.com> #4Dec 21, 2016 04:52AM

go...@gmail.com <go...@gmail.com> #5Dec 23, 2016 10:43PM

go...@gmail.com <go...@gmail.com> #6Dec 24, 2016 10:02AM

yb...@google.com <yb...@google.com> #7Dec 24, 2016 08:10PM

ta...@gmail.com <ta...@gmail.com> #8Dec 24, 2016 11:30PM

yb...@google.com <yb...@google.com> #9Dec 25, 2016 07:58AM

pr...@gmail.com <pr...@gmail.com> #10Jan 17, 2017 10:28AM

yb...@google.com <yb...@google.com> #11Jan 17, 2017 04:01PM

jo...@gmail.com <jo...@gmail.com> #12Jan 18, 2017 09:16AM

st...@googlemail.com <st...@googlemail.com> #13Jan 24, 2017 02:48PM

am...@google.com <am...@google.com> #14Feb 1, 2017 05:34AM

ta...@gmail.com <ta...@gmail.com> #15Feb 9, 2017 03:55AM

sk...@googlemail.com <sk...@googlemail.com> #16Feb 9, 2017 12:39PM

cc...@android.com <cc...@android.com> #17Feb 9, 2017 02:56PM

[Deleted User] <[Deleted User]> #18Feb 16, 2017 03:30AM

cc...@android.com <cc...@android.com> #19Feb 16, 2017 07:05PM

bf...@gmail.com <bf...@gmail.com> #20Feb 20, 2017 06:15AM

yu...@gmail.com <yu...@gmail.com> #21Feb 20, 2017 02:19PM

em...@gmail.com <em...@gmail.com> #22Feb 27, 2017 06:52PM

xl...@gmail.com <xl...@gmail.com> #23Mar 6, 2017 12:17PM

bf...@gmail.com <bf...@gmail.com> #24Mar 7, 2017 01:24PM

xl...@gmail.com <xl...@gmail.com> #25Mar 8, 2017 08:21AM

am...@google.com <am...@google.com> #26Apr 27, 2017 09:11AM

Add comment

Issue metadata