KeyStore Keys easily lost with poor UX [37099642]

Obsolete

Bug

[AOSP] assigned

Status Update

No update yet.

Description

do...@googlemail.com

created issue #1

May 19, 2016 04:53PM

This may not be classed as a bug but it causing a lot of difficulty for developers, and it did seem to be going the right direction until a regression to previous behaviour in M. I hoping that by raising here it may be possible to have some dialog with the Security team around this.

The issue is described in my blog post

http://doridori.github.io/android-security-the-forgetful-keystore/ and is essentially stored Keys in the KeyStore are easily lost if the user removes the lock screen or enrolls a new finger.

For me an ideal fix without reducing security would be...

Don't allow the user to downgrade device security by removing the lock screen _without_ a message saying "Apps X, Y and Z will lose data if you do this" i.e. some specific message as opposed to the current generic "device protection features will not work if you remove your [pattern|pin|password].

Showing a couple of app icons in this dialog for Key owners would be great, as at least the user is then informed as to the consequences of their actions, rather than just having their banking / other app broken on next launch without knowing why.

Would be fantastic to get someone on the team to talk about this :) Thx

Comments

sy...@google.com <sy...@google.com> #2May 19, 2016 06:07PM

Assigned to sy...@google.com.

For example:

@Composable
fun Foo(value: ImmutableCollection<Int>) {}

@Composable
fun Foo(value: PersistentList<Int>) {}

[Deleted User] <[Deleted User]> #3Dec 2, 2016 12:27PM

PersistentList is particularly relevant for hoisting List state with similar performance characteristics as SnapshotStateList for non-hoisted List state.

ma...@gmail.com <ma...@gmail.com> #4Apr 19, 2017 02:27PM

Given that the `immutableListOf`, `immutableSetOf` and `immutableMapOf` functions are all deprecated, it seems like we should be using the Persistent types. However this has a massive performance impact whilst this issue persists.

sw...@google.com <sw...@google.com> #5Apr 26, 2017 04:27PM

+1 vote, PersistentList is more useful than ImmutableList (for updating items)

do...@kodroid.com <do...@kodroid.com> #6Apr 27, 2017 08:38AM

Project: platform/frameworks/support
Branch: androidx-main

commit a91b7d222899c073168661eccc465034106f9895
Author: Andrew Bailey <anbailey@google.com>
Date: Mon Dec 05 11:39:51 2022

Make more of kotlinx.collections.immutable stable

This addresses two issues around stability inferencing for types in the
kotlinx.collections.immutable library. We have a few exceptions to treat
ImmutableList, ImmutableSet, and ImmutableMap as stable types, but we
don't have anything for ImmutableCollection or their Persistent
siblings. This CL adds those exceptions.

We also haven't marked any of their corresponding `*Of()` builders as
stable, which this CL also adds exceptions for.

Bug: 238057117
Bug: 254435410
Test: ClassStabilityTransformTests
Change-Id: Ie19290bfb53dd667e866681f11f266ae7bdb6201

M compose/compiler/compiler-hosted/integration-tests/src/test/java/androidx/compose/compiler/plugins/kotlin/ClassStabilityTransformTests.kt
M compose/compiler/compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/analysis/Stability.kt

https://android-review.googlesource.com/2328593

[Deleted User] <[Deleted User]> #7Jul 25, 2017 08:52PM

Thanks for the report! This is addressed in CL 2328593. This should start to behave as expected in an upcoming version of the Compose compiler.

is...@google.com <is...@google.com> Oct 5, 2018 07:14AM

Status: New

[Deleted User] <[Deleted User]> #8Feb 16, 2019 11:22PM

Wonderful, can't wait. Thank you!

ad...@google.com <ad...@google.com> #9Sep 4, 2020 12:33PM

Status: Won't Fix (Obsolete)

Which compose version does include this change?