Jill generates incorrect instructions for swap and dup [37087229]

Fixed

Bug

[AOSP] assigned

[AOSP] Released

[AOSP] FutureRelease

Status Update

No update yet.

Description

mi...@gmail.com

created issue #1

Mar 12, 2016 01:18PM

Next java bytecode transformed to incorrect jack one (tries to assign object to primitive int):

// access flags 0x19
public final static test()V
L0
LINENUMBER 118 L0
BIPUSH 11
NEW kotlin/ranges/IntRange
DUP_X1
SWAP
BIPUSH 12
INVOKESPECIAL kotlin/ranges/IntRange.<init> (II)V
POP
L1
LINENUMBER 119 L1
RETURN
L2
MAXSTACK = 4
MAXLOCALS = 0

transformed to
{
0 : {
}
-s_0_I = 11;
-s_1_R = alloc <IntRange>;
-s_2_R = -s_1_R;
-s_1_I = -s_0_I;
-s_0_R = -s_2_R;
-swap_tmp_R = -s_1_I;
-s_1_I = -s_2_R;
-s_2_R = -swap_tmp_R;
-s_3_I = 12;
-s_1_R.<init>(-s_2_I, -s_3_I);
9 : {
}
return;
} (simple.kt:2-3)

And TypeLegalizer:196 (case ASG: { JExpression castTo = maybeBoxOrUnbox(rhs, lhsType);)...}) tries cast Range value to primitive int "-s_1_I = -s_2_R;"

Seems bug linked with

https://code.google.com/p/android/issues/detail?id=196084

simple.kt

24 B

Download

SimpleKt.class

418 B

Download

Comments

mi...@gmail.com <mi...@gmail.com> #2Mar 12, 2016 01:29PM

Result exception:
16:33:57.626: SEVERE: com.android.jack.CommandLine: Internal compiler error (version 1.2-a17 'Carnac' (268301 7c1d57671582be81577d57feb3246ce4ff31e518)):
com.android.sched.scheduler.RunnerProcessException: Error during 'TypeLegalizer' runner on 'public static final void SimpleKt.test() (simple.kt:2-3)': Unexpected error during visit: com.android.jack.ir.ast.JAsgOperation at "simple.kt:2-3"
at com.android.sched.scheduler.ScheduleInstance.runWithLog(ScheduleInstance.java:163)
at com.android.sched.scheduler.MultiWorkersScheduleInstance$SequentialTask.process(MultiWorkersScheduleInstance.java:442)
at com.android.sched.scheduler.MultiWorkersScheduleInstance$Worker.run(MultiWorkersScheduleInstance.java:162)
Caused by: com.android.jack.ir.JNodeInternalError: Unexpected error during visit: com.android.jack.ir.ast.JAsgOperation at "simple.kt:2-3"
at com.android.jack.ir.ast.JVisitor.wrapException(JVisitor.java:102)
at com.android.jack.ir.ast.JVisitor.accept(JVisitor.java:55)
at com.android.jack.ir.ast.JExpressionStatement.traverse(JExpressionStatement.java:54)
at com.android.jack.ir.ast.JVisitor.accept(JVisitor.java:62)
at com.android.jack.ir.ast.JBlock.traverse(JBlock.java:41)
at com.android.jack.ir.ast.JVisitor.accept(JVisitor.java:51)
at com.android.jack.ir.ast.JMethodBody.traverse(JMethodBody.java:96)
at com.android.jack.ir.ast.JVisitor.accept(JVisitor.java:51)
at com.android.jack.ir.ast.JMethod.visitChildren(JMethod.java:336)
at com.android.jack.ir.ast.JMethod.traverse(JMethod.java:262)
at com.android.jack.ir.ast.JVisitor.accept(JVisitor.java:51)
at com.android.jack.transformations.ast.TypeLegalizer.run(TypeLegalizer.java:369)
at com.android.jack.transformations.ast.TypeLegalizer.run(TypeLegalizer.java:72)
at com.android.sched.scheduler.ScheduleInstance.runWithLog(ScheduleInstance.java:161)
... 2 more
Caused by: java.lang.AssertionError
at com.android.jack.transformations.ast.TypeLegalizer.unbox(TypeLegalizer.java:418)
at com.android.jack.transformations.ast.TypeLegalizer.unbox(TypeLegalizer.java:436)
at com.android.jack.transformations.ast.TypeLegalizer.access$100(TypeLegalizer.java:79)
at com.android.jack.transformations.ast.TypeLegalizer$TypeLegalizerVisitor.maybeBoxOrUnbox(TypeLegalizer.java:345)
at com.android.jack.transformations.ast.TypeLegalizer$TypeLegalizerVisitor.endVisit(TypeLegalizer.java:196)
at com.android.jack.ir.ast.JBinaryOperation.traverse(JBinaryOperation.java:70)
at com.android.jack.ir.ast.JVisitor.accept(JVisitor.java:51)
... 14 more
com.android.sched.scheduler.RunnerProcessException: Error during 'TypeLegalizer' runner on 'public static final void SimpleKt.test() (simple.kt:2-3)': Unexpected error during visit: com.android.jack.ir.ast.JAsgOperation at "simple.kt:2-3"
at com.android.sched.scheduler.ScheduleInstance.runWithLog(ScheduleInstance.java:163)
at com.android.sched.scheduler.MultiWorkersScheduleInstance$SequentialTask.process(MultiWorkersScheduleInstance.java:442)
at com.android.sched.scheduler.MultiWorkersScheduleInstance$Worker.run(MultiWorkersScheduleInstance.java:162)
Caused by: com.android.jack.ir.JNodeInternalError: Unexpected error during visit: com.android.jack.ir.ast.JAsgOperation at "simple.kt:2-3"
at com.android.jack.ir.ast.JVisitor.wrapException(JVisitor.java:102)
at com.android.jack.ir.ast.JVisitor.accept(JVisitor.java:55)
at com.android.jack.ir.ast.JExpressionStatement.traverse(JExpressionStatement.java:54)
at com.android.jack.ir.ast.JVisitor.accept(JVisitor.java:62)
at com.android.jack.ir.ast.JBlock.traverse(JBlock.java:41)
at com.android.jack.ir.ast.JVisitor.accept(JVisitor.java:51)
at com.android.jack.ir.ast.JMethodBody.traverse(JMethodBody.java:96)
at com.android.jack.ir.ast.JVisitor.accept(JVisitor.java:51)
at com.android.jack.ir.ast.JMethod.visitChildren(JMethod.java:336)
at com.android.jack.ir.ast.JMethod.traverse(JMethod.java:262)
at com.android.jack.ir.ast.JVisitor.accept(JVisitor.java:51)
at com.android.jack.transformations.ast.TypeLegalizer.run(TypeLegalizer.java:369)
at com.android.jack.transformations.ast.TypeLegalizer.run(TypeLegalizer.java:72)
at com.android.sched.scheduler.ScheduleInstance.runWithLog(ScheduleInstance.java:161)
... 2 more
Caused by: java.lang.AssertionError
at com.android.jack.transformations.ast.TypeLegalizer.unbox(TypeLegalizer.java:418)
at com.android.jack.transformations.ast.TypeLegalizer.unbox(TypeLegalizer.java:436)
at com.android.jack.transformations.ast.TypeLegalizer.access$100(TypeLegalizer.java:79)
at com.android.jack.transformations.ast.TypeLegalizer$TypeLegalizerVisitor.maybeBoxOrUnbox(TypeLegalizer.java:345)
at com.android.jack.transformations.ast.TypeLegalizer$TypeLegalizerVisitor.endVisit(TypeLegalizer.java:196)
at com.android.jack.ir.ast.JBinaryOperation.traverse(JBinaryOperation.java:70)
at com.android.jack.ir.ast.JVisitor.accept(JVisitor.java:51)
... 14 more

gc...@google.com <gc...@google.com> Mar 12, 2016 01:30PM

Assigned to mi...@google.com.

jp...@google.com <jp...@google.com> Mar 15, 2016 02:28PM

Marked as fixed.

mi...@gmail.com <mi...@gmail.com> #3Apr 6, 2016 09:59AM

Bug in swap instruction processing only.
Here is the patch:

swap_fix.patch

2.5 KB

Download

Issue 37087229

Description

Issue summary

Comments

mi...@gmail.com <mi...@gmail.com> #2Mar 12, 2016 01:29PM

gc...@google.com <gc...@google.com> Mar 12, 2016 01:30PM

jp...@google.com <jp...@google.com> Mar 15, 2016 02:28PM

mi...@gmail.com <mi...@gmail.com> #3Apr 6, 2016 09:59AM

Add comment

Issue metadata