Fixed
Status Update
Comments
am...@google.com <am...@google.com> #2
I think we can close this, I suspect it's actually just a symptom of
API 34
16:39:03.486 I GreetingScreen composed
16:39:03.576 I GreetingScreen focus=true
16:39:09.165 I GreetingScreen onDispose
16:39:09.165 I ListScreen composed
16:39:09.214 I ListScreen focus=true
16:39:12.236 I GreetingScreen composed
16:39:12.269 I GreetingScreen focus=false
16:39:35.427 I GreetingScreen onDispose
API 35
16:39:52.460 I GreetingScreen composed
16:39:52.551 I GreetingScreen focus=true
16:40:09.212 I ListScreen composed
16:40:09.272 I ListScreen focus=true
16:40:10.118 I GreetingScreen onDispose
16:40:11.049 I GreetingScreen composed
16:40:11.061 I GreetingScreen focus=true
16:40:16.482 I GreetingScreen onDispose
an...@gmail.com <an...@gmail.com> #3
Added a few more tests, the underlying HFC machinery seems to be working.
am...@google.com <am...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
Author: Sergio Sancho <
Link:
Adding test to HFC
Expand for full commit details
Adding test to HFC
Relnote: Adding tests
Test: Added.
Bug: 395548918
Change-Id: I1ce54d56ef24665053a6179816aefd70cb9d9453
Files:
- M
wear/compose/compose-foundation/src/androidTest/kotlin/androidx/wear/compose/foundation/HierarchicalFocusCoordinatorTest.kt
Hash: ed5e91166781ad305868bbb9e2d1ad76df317c6b
Date: Mon Feb 10 16:54:32 2025
an...@gmail.com <an...@gmail.com> #5
Good news! Wear Compose has been updated to ab/13046075 in https://critique.corp.google.com/cl/732905175 and this bug has been affected.
am...@google.com <am...@google.com> #6
Ok fine, after clicking on each button, we see the issue right. button clicks are not observable from the video you have attached.
BTW, We have passed this defect on to the development team and will update this issue with more information as it becomes available.
Thanks
BTW, We have passed this defect on to the development team and will update this issue with more information as it becomes available.
Thanks
am...@google.com <am...@google.com> #7
Hi,
The development team has fixed the issue that you have reported and it will be available in a future build
Thanks
The development team has fixed the issue that you have reported and it will be available in a future build
Thanks
an...@gmail.com <an...@gmail.com> #8
Hi, Could you please let us know whether it is an issue from AppCompat or it is an issue from the sample code of AppCompat? And based on the fact that this issue could be reproduced easily on any device target 23, it undermines my confidence in the quality of code in AppCompat. How could it pass the test at the very beginning?
am...@google.com <am...@google.com> #9
It's issue with AppCompatActivity.java of support library which is fixed now.
ps...@gmail.com <ps...@gmail.com> #10
[Comment deleted]
ps...@gmail.com <ps...@gmail.com> #11
Issue is not fully fixed. I'm using "values-night" plus normal "values"
directories as well as
android:configChanges="orientation|screenSize".
But when performing orientation change, the colors inside "values-night"
get confused with "values" colors for some components like recyclerview
items and newly created fragments. I will upload a sample project that
reproduces the issue.
Στις 11 Μαρ 2016 2:42 πμ, ο χρήστης <android@googlecode.com> έγραψε:
directories as well as
android:configChanges="orientation|screenSize".
But when performing orientation change, the colors inside "values-night"
get confused with "values" colors for some components like recyclerview
items and newly created fragments. I will upload a sample project that
reproduces the issue.
Στις 11 Μαρ 2016 2:42 πμ, ο χρήστης <android@googlecode.com> έγραψε:
ke...@teslacoilsw.com <ke...@teslacoilsw.com> #12
I'm also still having some of the wrong resources being used. Additionally, the Support7Demo's AlertDialog demo still doesn't work, the dialogs are all light. The Dialog (not AlertDialog) demo does work.
Nexus 6P 6.0.1 and Galaxy S5 5.0
Nexus 6P 6.0.1 and Galaxy S5 5.0
ps...@gmail.com <ps...@gmail.com> #13
I modified the cheesesquare project to let you know what I mean.
App starts on night mode explicitly. While on night mode, rotate your phone to landscape scroll a little bit then rotate to portrait scroll again. A glitch appears where resources from default "values" (light theme) are being used instead.
check it out here
https://github.com/ThanosFisherman/cheesesquare
App starts on night mode explicitly. While on night mode, rotate your phone to landscape scroll a little bit then rotate to portrait scroll again. A glitch appears where resources from default "values" (light theme) are being used instead.
check it out here
ke...@teslacoilsw.com <ke...@teslacoilsw.com> #14
Re: #13
I think something along the lines of the following snippet will work around the specific issue you're having. This worked for me, though I suspect it needs more fleshing out to handle auto night mode and to handle N's system toggle.
@Override
public void onConfigurationChanged(Configuration newConfig) {
int currentNightMode = getResources().getConfiguration().uiMode
& Configuration.UI_MODE_NIGHT_MASK;
if (currentNightMode == Configuration.UI_MODE_NIGHT_YES)
newConfig.uiMode = (newConfig.uiMode & ~Configuration.UI_MODE_NIGHT_MASK) | Configuration.UI_MODE_NIGHT_YES;
super.onConfigurationChanged(newConfig);
}
I'm having issues with mixed resources but am not handling configuration changes. I haven't been able to make a test case yet. In my setup first time viewing the activity in either or dark works and then toggling once works, but toggling back to the original state keeps some elements of the other, like the list dividers and vector drawables that were tinted to ?attr/colorControlActivated. My setup does work if I just switch between using a light and dark theme, it's the -night values that throws things off. I'm not concerned that what appcompat daynight is trying to do can be done reliably and I'll need my dark theme independent of -night, and -night just to handle N.
I think something along the lines of the following snippet will work around the specific issue you're having. This worked for me, though I suspect it needs more fleshing out to handle auto night mode and to handle N's system toggle.
@Override
public void onConfigurationChanged(Configuration newConfig) {
int currentNightMode = getResources().getConfiguration().uiMode
& Configuration.UI_MODE_NIGHT_MASK;
if (currentNightMode == Configuration.UI_MODE_NIGHT_YES)
newConfig.uiMode = (newConfig.uiMode & ~Configuration.UI_MODE_NIGHT_MASK) | Configuration.UI_MODE_NIGHT_YES;
super.onConfigurationChanged(newConfig);
}
I'm having issues with mixed resources but am not handling configuration changes. I haven't been able to make a test case yet. In my setup first time viewing the activity in either or dark works and then toggling once works, but toggling back to the original state keeps some elements of the other, like the list dividers and vector drawables that were tinted to ?attr/colorControlActivated. My setup does work if I just switch between using a light and dark theme, it's the -night values that throws things off. I'm not concerned that what appcompat daynight is trying to do can be done reliably and I'll need my dark theme independent of -night, and -night just to handle N.
ps...@gmail.com <ps...@gmail.com> #15
[Comment deleted]
ps...@gmail.com <ps...@gmail.com> #16
[Comment deleted]
ps...@gmail.com <ps...@gmail.com> #17
[Comment deleted]
mn...@gmail.com <mn...@gmail.com> #18
Same issue is not fixed, we are seeing it within our app. When we come through a deep link with night mode enabled, scrolling down through a recyclerview shows some view holders as applying non -night values.
ai...@gmail.com <ai...@gmail.com> #19
Can confirm issue is not fixed with support library 25.1.0
dr...@gmail.com <dr...@gmail.com> #20
Can confirm issue is not fixed with support library 26.0.0
zf...@gmail.com <zf...@gmail.com> #21
confirm issue is not fixed with support library 25.4.0
pa...@gmail.com <pa...@gmail.com> #22
Also having problems with wrong resources using 26.0.0
Rotating from landscape -> portrait -> landscape works fine however going from landscape (left) -> landscape (right) messes up the resources. Most of the existing UI looks fine but all new views receives the wrong resources.
Rotating from landscape -> portrait -> landscape works fine however going from landscape (left) -> landscape (right) messes up the resources. Most of the existing UI looks fine but all new views receives the wrong resources.
jo...@gmail.com <jo...@gmail.com> #23
confirm issue is not fixed with support library 25.0.0 .
jo...@gmail.com <jo...@gmail.com> #24
Now, i got this bug in android 8.1, after rotate phone, some new widget got error resource.
vl...@desygner.com <vl...@desygner.com> #25
This issue definitely isn't fixed yet, getting it starting with Android 5.0. I found the easiest way to reproduce it 100% is to implement Lokalise SDK here https://github.com/lokalise/lokalise-android-sdk and then -night colors won't be used for new views (RecyclerView items, dialog views, etc.) as soon as onStop() is called, e.g. after going to another activity and coming back or putting the app to background and bringing it back to front. Please fix this!
ro...@gmail.com <ro...@gmail.com> #26
After 3 years this is still not fixed. The theme -night colors works when an app first starts, but then any subsequent starts from the desktop reverts colors back to non-night ones. As indicated, it looks like any onStop() will mess future starts of an application.
ri...@gmail.com <ri...@gmail.com> #27
Try calling the delegator method on the very first screen your app opens. I was having the same problem and it is starts working once I move the delegator code to the very first screen i.e. Splash Screen.
Description
Version used: 23.2.0
Theme used:
Devices/Android versions reproduced on: Nexus 5 with API 23
- Relevant code to trigger the issue: support7Demos under directory /Android/sdk/extras/android/support/samples/Support7Demos
- A screenrecord or screenshots showing the issue (if UI related).
0
down vote
favorite
I have downloaded the Android Support 23.2.0 and imported support7Demos under directory /Android/sdk/extras/android/support/samples/Support7Demos without making any changes. After importing the necessary dependencies, it builds successfully and generate an apk. I installed the apk on Smartisan T1 with API 19. The day night mode works as expected. But it does not work on Nexus 5 with API 23.
Please be noticed that
1, the code is from the Android official Support V7 sample, I did not make any changes at all. The same apk installed on different devices work different.
2,I have linked the apk file and videos in the attachment.
3, this issue could be stably reproduced and this issue occurs in Nexus 6P in emulator which installs MarshMallow while it works perfect in SamSung Galaxy 3 which installs JellyBean.
Is it a bug? And if it is a bug, is there any workaround?