Recycler view crashes when recycling some view holders [37124073]

Fixed

Bug

[AOSP] FutureRelease

Status Update

No update yet.

Description

ni...@ansman.se

created issue #1

Oct 20, 2016 07:51PM

Library used (support-v4, appcompat-v7, ...): recyclerview-v7
Version used: 24.2.1

Stack trace:
Fatal Exception: java.lang.IllegalStateException: Already in the pool!
at android.support.v4.util.Pools$SimplePool.release(Pools.java:113)
at android.support.v7.widget.AdapterHelper.recycleUpdateOp(AdapterHelper.java:744)
at android.support.v7.widget.AdapterHelper.recycleUpdateOpsAndClearList(AdapterHelper.java:751)
at android.support.v7.widget.AdapterHelper.consumePostponedUpdates(AdapterHelper.java:124)
at android.support.v7.widget.AdapterHelper.consumeUpdatesInOnePass(AdapterHelper.java:558)
at android.support.v7.widget.RecyclerView.dispatchLayoutStep2(RecyclerView.java:3309)
at android.support.v7.widget.RecyclerView.dispatchLayout(RecyclerView.java:3124)
at android.support.v7.widget.RecyclerView.consumePendingUpdateOperations(RecyclerView.java:1539)
at android.support.v7.widget.RecyclerView.focusSearch(RecyclerView.java:2206)
at android.view.ViewGroup.focusSearch(ViewGroup.java:871)
at android.view.ViewGroup.focusSearch(ViewGroup.java:871)
at android.view.View.focusSearch(View.java:8649)
at android.widget.TextView.onCreateInputConnection(TextView.java:7327)
at android.support.design.widget.TextInputEditText.onCreateInputConnection(TextInputEditText.java:48)
at android.view.inputmethod.InputMethodManager.startInputInner(InputMethodManager.java:1530)
at android.view.inputmethod.InputMethodManager.checkFocus(InputMethodManager.java:1792)
at android.view.inputmethod.InputMethodManager.restartInput(InputMethodManager.java:1460)
at android.widget.TextView.setInputType(TextView.java:5236)
at com.mypackage.MyAdapter.onViewRecycled(MyAdapter.java:91)
at android.support.v7.widget.RecyclerView$Recycler.dispatchViewRecycled(RecyclerView.java:5525)
at android.support.v7.widget.RecyclerView$Recycler.addViewHolderToRecycledViewPool(RecyclerView.java:5290)
at android.support.v7.widget.RecyclerView$Recycler.recycleCachedViewAt(RecyclerView.java:5220)
at android.support.v7.widget.RecyclerView$Recycler.viewRangeUpdate(RecyclerView.java:5643)
at android.support.v7.widget.RecyclerView.viewRangeUpdate(RecyclerView.java:3834)
at android.support.v7.widget.RecyclerView$6.markViewHoldersUpdated(RecyclerView.java:774)
at android.support.v7.widget.AdapterHelper.dispatchFirstPassAndUpdateViewHolders(AdapterHelper.java:322)
at android.support.v7.widget.AdapterHelper.dispatchAndUpdateViewHolders(AdapterHelper.java:302)
at android.support.v7.widget.AdapterHelper.applyUpdate(AdapterHelper.java:222)
at android.support.v7.widget.AdapterHelper.preProcess(AdapterHelper.java:106)
at android.support.v7.widget.RecyclerView.consumePendingUpdateOperations(RecyclerView.java:1536)
at android.support.v7.widget.RecyclerView$ViewFlinger.run(RecyclerView.java:4389)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:920)
at android.view.Choreographer.doCallbacks(Choreographer.java:695)
at android.view.Choreographer.doFrame(Choreographer.java:628)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:906)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:158)
at android.app.ActivityThread.main(ActivityThread.java:7229)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120)

Comments

yb...@google.com <yb...@google.com> Oct 20, 2016 11:05PM

Assigned to yb...@google.com.

yb...@google.com <yb...@google.com> #2Oct 28, 2016 04:45PM

Can you provide the below requested information to better understand the issue:

Steps to reproduce
What steps do others need to take in order to reproduce the issue themselves?
Please provide sample application or apk to reproduce the issue.
Also kindly mention the steps to reproduce the issue using the sample application or apk.

Frequency
How frequently does this issue occur? (e.g 100% of the time, 10% of the time)

Expected output
What do you expect to occur?

Current output
What do you see instead?

si...@google.com <si...@google.com> #3Oct 28, 2016 06:07PM

Hi,

The issue happens 100% of the time when running espresso tests in the "ar_XB" locale. I am working on a sample app to show the issue.

Expected behavior would be successful rendering, but instead the app crashes when rendering the layout.

yb...@google.com <yb...@google.com> #4Oct 28, 2016 06:41PM

Hi,

I have added a sample project at

https://github.com/kkoser/SupportLibRTLCrash. The crash happens when running tests in the "ar_XB" (right to left psuedolocale) locale, but not in other RTL locales. The locale for the test is set in onStart() of the test runner. To reproduce this crash, just run the test in "ExampleInstrumentedTest.java" from Android Studio.

Let me know if there's any more information you need!

yb...@google.com <yb...@google.com> #5Oct 28, 2016 11:56PM

Marked as fixed.

We have passed this defect on to the development team and will update this issue with more information as it becomes available.

ni...@ansman.se <ni...@ansman.se> #6Oct 31, 2016 11:32AM

Looks like a Gradle plugin issue to me.

[Deleted User] <[Deleted User]> #7Jan 9, 2017 12:45AM

Just to clarify: the stack trace above happens on the device, not at build time?

pa...@gmail.com <pa...@gmail.com> #8Jul 11, 2019 12:15PM

Yes, this is happening on the device at runtime, not at build time.

yb...@google.com <yb...@google.com> Jul 11, 2019 04:07PM

Reassigned to sh...@google.com.

pa...@gmail.com <pa...@gmail.com> #9Aug 22, 2019 05:01PM

I can reproduce this, but it's something that the support lib should handle, I don't think this had anything to do with tools. It was introduced in support lib 25.x.

Over to you Teng-Hui.