widget.RecyclerView.assertNotInLayoutOrScroll possibly overextended [37084037]

Fixed

Bug

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

Feb 28, 2016 02:49AM

Library used (support-v4, appcompat-v7, ...): recyclerview
Version used: 23.2.0
Theme used: Theme.AppCompat
Devices/Android versions reproduced on: Nexus 6P - 6.0.1

- Relevant code to trigger the issue.

Run the app built from this branch, comes up in a few places namely around using a recyclerview with an InfiniteScrollListener:

https://github.com/hzsweers/plaid/tree/z/compat

- A screenrecord or screenshots showing the issue (if UI related).

N/A

Comments

za...@gmail.com <za...@gmail.com> #2Feb 28, 2016 02:50AM

Forgot to add the trace:

E/AndroidRuntime: FATAL EXCEPTION: main
Process: io.plaidapp, PID: 7022
java.lang.IllegalStateException: Cannot call this method while RecyclerView is computing a layout or scrolling
at android.support.v7.widget.RecyclerView.assertNotInLayoutOrScroll(RecyclerView.java:2161)
at android.support.v7.widget.RecyclerView$RecyclerViewDataObserver.onItemRangeInserted(RecyclerView.java:4275)
at android.support.v7.widget.RecyclerView$AdapterDataObservable.notifyItemRangeInserted(RecyclerView.java:9948)
at android.support.v7.widget.RecyclerView$Adapter.notifyItemInserted(RecyclerView.java:5850)
at io.plaidapp.ui.FeedAdapter.dataStartedLoading(FeedAdapter.java:638)
at io.plaidapp.data.BaseDataManager.dispatchLoadingStartedCallbacks(BaseDataManager.java:166)
at io.plaidapp.data.BaseDataManager.loadStarted(BaseDataManager.java:73)
at io.plaidapp.data.DataManager.loadSource(DataManager.java:78)
at io.plaidapp.data.DataManager.loadAllDataSources(DataManager.java:59)
at io.plaidapp.ui.HomeActivity$4.onLoadMore(HomeActivity.java:189)
at io.plaidapp.ui.recyclerview.InfiniteScrollListener.onScrolled(InfiniteScrollListener.java:54)
at android.support.v7.widget.RecyclerView.dispatchOnScrolled(RecyclerView.java:3948)
at android.support.v7.widget.RecyclerView.dispatchLayoutStep3(RecyclerView.java:3102)
at android.support.v7.widget.RecyclerView.dispatchLayout(RecyclerView.java:2914)
at android.support.v7.widget.RecyclerView.consumePendingUpdateOperations(RecyclerView.java:1430)
at android.support.v7.widget.RecyclerView.access$400(RecyclerView.java:147)
at android.support.v7.widget.RecyclerView$1.run(RecyclerView.java:285)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:858)
at android.view.Choreographer.doCallbacks(Choreographer.java:670)
at android.view.Choreographer.doFrame(Choreographer.java:603)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:844)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:5417)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

dn...@google.com <dn...@google.com> Feb 29, 2016 06:21AM

Assigned to dn...@google.com.

dn...@google.com <dn...@google.com> #3Feb 29, 2016 08:53AM

Status: New

I am facing some issues while building the attached project so please share the test apk with us to test this issue.

Note: Please upload the files to google drive and share the folder to android-bugreport@google.com, then share the link here.

al...@gmail.com <al...@gmail.com> #4Feb 29, 2016 10:40AM

+1 the same crash after updating to 23.2.0

yb...@google.com <yb...@google.com> #5Feb 29, 2016 05:52PM

Assigned to yb...@google.com.

I can reproduce this, no need for an app.

yb...@google.com <yb...@google.com> Mar 1, 2016 05:47PM

Marked as fixed.

la...@gmail.com <la...@gmail.com> #6Mar 2, 2016 12:33AM

+1 I also am seeing this crash in the latest recyclerview update.

tm...@gmail.com <tm...@gmail.com> #7Mar 2, 2016 10:40PM

I was faced this problem.

To avoid this problem, I added this code to my onScrolled method.

if (dx == 0 && dy == 0) return

It seems to work well.

-----
@Override
public void onScrolled(RecyclerView recyclerView, int dx, int dy) {
super.onScrolled(recyclerView, dx, dy);

--> if (dx == 0 && dy == 0) return

...