Request: Add dark theme for CardView [37070882]

Fixed

Feature Request

[AOSP] assigned

[AOSP] Released

Status Update

No update yet.

Description

lb...@gmail.com

created issue #1

Nov 18, 2015 04:59PM

Reason: Because dark themed apps also deserve cardViews, without showing white cards on black background ...

Some screens also work better with dark themes (like OLED), so this is also nice for this purpose.

Comments

lb...@gmail.com <lb...@gmail.com> #2Nov 18, 2015 05:00PM

Project: platform/frameworks/support
Branch: androidx-main

commit b6c7c78f9e7476b468dafe9d5f7dec6794d47f09
Author: Shahd AbuDaghash <shahddaghash@google.com>
Date: Mon Nov 27 11:16:51 2023

Introduce DecayAnimation in AnchoredDraggable

Decay animation allows more realistic settling of a component. This is performed by now passing a `DecayAnimationSpec` parameter to AnchoredDraggable and using it when animating to the target. The new animation implementation will be added in a chain CL.

Bug: 288084801
Test: Tests will be added in a chain CL
Relnote: This change adds a `decayAnimationSpec` parameter to AnchoredDraggable allowing to use decay animation when settling to one of the anchors. The change also includes renaming the existing `animationSpec` to `snapAnimationSpec` to help understanding the use case of each spec.
Change-Id: I44ccd408d919328fd6504d31d8db59cf1d07de43

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/AnchoredDraggableSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/anchoredDraggable/AnchoredDraggableGestureTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/anchoredDraggable/AnchoredDraggableStateTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/AnchoredDraggable.kt

https://android-review.googlesource.com/2847074

al...@android.com <al...@android.com> Nov 18, 2015 05:43PM

Assigned to au...@google.com.

lb...@gmail.com <lb...@gmail.com> #3Nov 18, 2015 05:46PM

Project: platform/frameworks/support
Branch: androidx-main

commit 365993d1a90c27704b71f6bee042a1749314a4b1
Author: Shahd AbuDaghash <shahddaghash@google.com>
Date: Tue Nov 28 10:49:56 2023

Add tests for Animation in AnchoredDraggable

Added tests to check for different settling behaviors.

Bug: 288084801
Test: Added tests to verify behavior.
Change-Id: I369b30c69f7c29f676ae0671fef25c38ff3c74cb

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/anchoredDraggable/AnchoredDraggableStateTest.kt

https://android-review.googlesource.com/2847475

ch...@google.com <ch...@google.com> #4Nov 18, 2015 05:52PM

Project: platform/frameworks/support
Branch: androidx-main

commit ff1a600df5f4d8ae21a75d8e3e0f24d6c5c2faee
Author: Shahd AbuDaghash <shahddaghash@google.com>
Date: Mon Nov 27 15:51:12 2023

Modify settle function to perform decay animation if possible

When settling, a check will be performed to see if natural decay animation can be used. If not so, a target animation will be used. The consumed velocity is returned to the settle function, which could be used to show an overscroll effect.

Bug: 288084801
Test: Tests will be added in a chain CL.
Relnote: This change introduces a new `animateToWithDecay` function that naturally decays if possible. It takes the target value and the initial velocity. The `animateTo` functions no longer takes a velocity, but passes the available velocity in `lastVelocity` to animation, as it is concerned with reaching the target. If users need to pass a certain velocity for animation, they can use `animateToWithDecay` function.
Change-Id: I465dbd826e3969b784d08c65425f4bbda3de8493

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/AnchoredDraggable.kt

https://android-review.googlesource.com/2847576

lb...@gmail.com <lb...@gmail.com> #5Nov 18, 2015 07:00PM

Project: platform/frameworks/support
Branch: androidx-main

commit 01142ddd5b14eb33e5145c4e72e6619a5c100fe4
Author: Shahd AbuDaghash <shahddaghash@google.com>
Date: Thu Dec 21 12:34:00 2023

Introduce Overscroll in AnchoredDraggable

Adding overscroll support to AnchoredDraggable by giving the ability to pass a customized overscrollEffect object to AnchoredDraggable.

Bug: 288084801
Relnote: An OverscrollEffect has been introduced to allow for custom overscroll effects in anchoredDraggable. To retrieve the consumed velocity after animation, the consumed velocity is returned from the settle function.
Test: Added tests to verify behavior
Change-Id: I100683fe7473b1e5ff317ab22245a2b0a25bd549

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/AnchoredDraggableDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/AnchoredDraggableSample.kt
A compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/anchoredDraggable/AnchoredDraggableOverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/AnchoredDraggable.kt

https://android-review.googlesource.com/2888106

deleted

Restricted

0 B

au...@google.com <au...@google.com> #6Nov 20, 2015 09:51PM

Status: Won't Fix (Intended Behavior)

Project: platform/frameworks/support
Branch: androidx-main

commit 0f071d797bccf7eff2a23e408928ca76640af782
Author: Shahd AbuDaghash <shahddaghash@google.com>
Date: Wed Nov 29 18:34:09 2023

Migrates AnchoredDraggable to Modifier.Node

Migrates AnchoredDraggable to Modifier.Node. This helps in adding Overscroll effect in AnchoredDraggable.

Bug: 288084801
Test: Added tests to verify behavior
Change-Id: I3f3338cd71763972c4b70f2e06c97e85285b0035

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/anchoredDraggable/AnchoredDraggableGestureTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/AnchoredDraggable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Draggable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Draggable2D.kt

https://android-review.googlesource.com/2852691

lb...@gmail.com <lb...@gmail.com> #7Nov 20, 2015 10:00PM

This issue is marked as fixed, but there is still no replacement for ResistanceConfig.

How should we properly migrate it?

lb...@gmail.com <lb...@gmail.com> #8Nov 20, 2015 11:02PM

Can we document this / update the migration guide?

al...@android.com <al...@android.com> Mar 11, 2016 12:43AM

Marked as fixed.

lb...@gmail.com <lb...@gmail.com> #9Mar 15, 2016 09:28AM

@10 How do I use the new dark theme for the cardView ?

au...@google.com <au...@google.com> #10Mar 16, 2016 06:18PM

You can use CardView.Dark style if you want it explicitly set, otherwise it should pick it up from your activity theme if you use the right context. Does that work for you?

lb...@gmail.com <lb...@gmail.com> #11Mar 17, 2016 12:03AM

@12 Indeed. And if someone wishes to just use the colors (since cards might also be selected or have other effects), I see that it's ok to also use cardview_light_background and cardview_dark_background as the colors (using setCardBackgroundColor or app:cardBackgroundColor ).

Thank you.