BottomNavigationView replace the existing menu [37130153]

Fixed

Bug

[AOSP] assigned

[AOSP] Released

[AOSP] FutureRelease

Status Update

No update yet.

Description

sc...@gmail.com

created issue #1

Dec 15, 2016 01:57PM

Hi,

I's impossible to replace the menu of a BottomNavigationView.

If you do a clear on the menu before, you got the following exception : java.lang.IllegalStateException: Already in the pool!

If you don't do the clear, it will add the new menu at the end of the old one until you get more than 5 items then you'll get java.lang.IllegalArgumentException: Maximum number of items supported by BottomNavigationView is 5

Expected : A clear followed by an inflate should replace the old menu and should not throw an exception

Nexus 5x
Android 7.1.1
Build tools : 25.0.2
Support design : 25.1.0

CrashBottomNavigation.zip

671 KB

Download

Comments

am...@google.com <am...@google.com> #2Dec 16, 2016 05:29AM

Assigned to am...@google.com.

Hi,
We have passed this defect on to the development team and will update this issue with more information as it becomes available.
Thanks

sa...@gmail.com <sa...@gmail.com> #3Dec 16, 2016 09:40PM

Thought I should mention for posterity, a temporary workaround is:

mStaggeredGridLayoutManager.setItemPrefetchEnabled(false);

sa...@gmail.com <sa...@gmail.com> #4Dec 16, 2016 09:51PM

[Comment deleted]

am...@google.com <am...@google.com> #5Jan 4, 2017 04:38AM

Marked as fixed.

The bug is reproduced on physical device.

1. RecyclerView with GridLayoutManager (3 column)
2. All items has span = 3 (grid look like simple list)
3. Scrolling up and down is working fine
4. Insert items in the middle of the list (All inserted items has span 3 too)
5. call to notifyDataChanged()
6. Grid is expanded with animation
6. Scrolling up and down is failed.

Problem is found after adding android:animateLayoutChanges="true" into a parent layout.
Bug reproducing is stable.

sc...@gmail.com <sc...@gmail.com> #6Jan 4, 2017 07:05AM

Bug reproduced id add "android:animateLayoutChanges="true" to list item layout:

RecycleView
--Root Item view layout is: RelativeLayout
----LinearLayout
--------ViewPager
----------Page0: is <LinearLayout... "android:animateLayoutChanges="true".../> <-- this attr is the bug reason

am...@google.com <am...@google.com> #7Feb 1, 2017 05:30AM

You cannot use android:animateLayoutChanges with RecyclerView.
It will try to animate children of the RecyclerView and conflict with the ItemAnimator.

You can still use TransitionManager directly (which that attribute uses) but make sure to exclude RecyclerView's children.

yy...@gmail.com <yy...@gmail.com> #8Jun 24, 2017 08:58AM

Hi, original reporter here. I did not use animateLayoutChanges. See example project in original report.