Export to GitHub

v8cgi - issue #93

Using up all the memory during aborted uploads


Posted on May 26, 2011 by Happy Elephant

What steps will reproduce the problem? 1. Random "out of memory" crashes when people upload a lot & some of the uploads are disconnected.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system? svn v8 + v8cgi apache httpd 2.2.17

Please provide any additional information below.

In the apache2's modules/http/http_filters.c

It says that ap_setup_client_block will return -1 sometimes...

  • It will put data into the buffer (not necessarily a full buffer), and
  • return the length of the input block. When it is done reading, it will
  • return 0 if EOF, or -1 if there was an error.
  • If an error occurs on input, we force an end to keepalive. *

Apache themselves have this problem too I have reported it... https://issues.apache.org/bugzilla/show_bug.cgi?id=51239

Attachments

Comment #1

Posted on May 26, 2011 by Happy Giraffe

(No comment was entered for this change.)

Comment #2

Posted on Jun 13, 2011 by Happy Giraffe

Commited in r915, thanks a lot!

Status: Fixed

Labels:
Type-Defect Priority-Medium