
the-bus-pirate - issue #64
bpxsvfplayer utility has a major bug in serial initialization
You are passing a string! (uh..) to the serial_setup and to the cfsetispeed. That is very wrong and won't work (or at least shouldn't..).
The attached patch fixes it with simple atoi call and no error checking there I admit.
The result performs flawlessly on linux and Mac OS 10.6.
--- main.c.old 2011-10-03 00:00:44.000000000 +0200 +++ main.c.new 2011-10-03 00:01:44.000000000 +0200 @@ -183,7 +183,7 @@ }
//setup port and speed
- serial_setup(fd,(speed_t) param_speed); + serial_setup(fd,(speed_t) atoi(param_speed));
if (jtag_reset==TRUE){
printf(" Performing Reset..\n");
Comment #1
Posted on Oct 3, 2011 by Happy Giraffecommitted, thanks!
Status: Fixed
Labels:
Type-Defect
Priority-Medium