Export to GitHub

subprocdev - issue #7

clean up the tests


Posted on Feb 5, 2011 by Happy Dog

What steps will reproduce the problem? 1. Run tests using a pure Windows build of Python 2.6.

What is the expected output? What do you see instead? All tests should pass.

Instead I saw an assertion error in test_module with regards to the CR character introduced by the Windows C library when the higher layer writes just an NL.

I also saw a failure in test_longrunning's p.asyncwrite(), stopping in WriteFile() because "The pipe is being closed".

What version of the product are you using? On what operating system?

Headrev. Windows XP Pro 2002 SP3.

Please provide any additional information below.

I am attaching a patch that will ignore new line conversion. Perhaps, it would be better to request universal newlines in Popen calls and/or set the binary mode on pipe file handles belonging to the testing process.

I also found that test_longrunning() has two definitions in the unit test class. The patch removes one of the definitions.

Attachments

Status: New

Labels:
Type-Defect Priority-Medium